Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 1888963004: Add HttpProtocolHandler and convert everything to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-supports-scheme
Patch Set: more addressing comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 51b690824301e8a7bcdb5cbd1f2333d4469858f6..62be9bb28c08343020b4ed8e05abe0cb9e37e32b 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -243,32 +243,6 @@ const BoundNetLog& URLRequestHttpJob::HttpFilterContext::GetNetLog() const {
return job_->request() ? job_->request()->net_log() : dummy_log_;
}
-// TODO(darin): make sure the port blocking code is not lost
-// static
-URLRequestJob* URLRequestHttpJob::Factory(URLRequest* request,
- NetworkDelegate* network_delegate,
- const std::string& scheme) {
- DCHECK(scheme == "http" || scheme == "https" || scheme == "ws" ||
- scheme == "wss");
-
- if (!request->context()->http_transaction_factory()) {
- NOTREACHED() << "requires a valid context";
- return new URLRequestErrorJob(
- request, network_delegate, ERR_INVALID_ARGUMENT);
- }
-
- GURL redirect_url;
- if (request->GetHSTSRedirect(&redirect_url)) {
- return new URLRequestRedirectJob(
- request, network_delegate, redirect_url,
- // Use status code 307 to preserve the method, so POST requests work.
- URLRequestRedirectJob::REDIRECT_307_TEMPORARY_REDIRECT, "HSTS");
- }
- return new URLRequestHttpJob(request,
- network_delegate,
- request->context()->http_user_agent_settings());
-}
-
URLRequestHttpJob::URLRequestHttpJob(
URLRequest* request,
NetworkDelegate* network_delegate,

Powered by Google App Engine
This is Rietveld 408576698