Add HttpProtocolHandler and convert everything to use it

net/url_request/url_request_http_job_unittest.cc

Index: net/url_request/url_request_http_job_unittest.cc
diff --git a/net/url_request/url_request_http_job_unittest.cc b/net/url_request/url_request_http_job_unittest.cc
index 8a8cdfeb1fc873e9a58d355143b487217a0b14a9..6da26a864f51f715c024368a7a2b56a2ea4982a9 100644
--- a/net/url_request/url_request_http_job_unittest.cc
+++ b/net/url_request/url_request_http_job_unittest.cc
@@ -24,6 +24,7 @@
 #include "net/socket/socket_test_util.h"
 #include "net/test/cert_test_util.h"
 #include "net/url_request/url_request.h"
+#include "net/url_request/url_request_intercepting_job_factory.h"
 #include "net/url_request/url_request_job_factory_impl.h"
 #include "net/url_request/url_request_status.h"
 #include "net/url_request/url_request_test_util.h"
@@ -56,14 +57,17 @@ class TestURLRequestHttpJob : public URLRequestHttpJob {
 
 class URLRequestHttpJobTest : public ::testing::Test {
  protected:
-  URLRequestHttpJobTest() : context_(true) {
+  URLRequestHttpJobTest()
+      : test_job_factory_(
+            URLRequestJobFactoryImpl::CreateWithHttpProtocolHandlers()),
+        context_(true) {
     context_.set_http_transaction_factory(&network_layer_);
 
     // The |test_job_factory_| takes ownership of the interceptor.
     test_job_interceptor_ = new TestJobInterceptor();
-    EXPECT_TRUE(test_job_factory_.SetProtocolHandler(
-        url::kHttpScheme, base::WrapUnique(test_job_interceptor_)));
-    context_.set_job_factory(&test_job_factory_);
+    test_job_factory_.reset(new URLRequestInterceptingJobFactory(
+        std::move(test_job_factory_), base::WrapUnique(test_job_interceptor_)));

[mmenke, 2016/04/28 16:52:41]

Suggest just inlining URLRequestJobFactoryImpl::CreateWithHttpProtocolHandlers()
here, instead of setting test_job_factory_, and then changing its value.

[mgersh, 2016/04/28 20:36:30]

Done.

+    context_.set_job_factory(test_job_factory_.get());
 
     context_.Init();
 
@@ -106,7 +110,7 @@ class URLRequestHttpJobTest : public ::testing::Test {
 
   // |test_job_interceptor_| is owned by |test_job_factory_|.
   TestJobInterceptor* test_job_interceptor_;
-  URLRequestJobFactoryImpl test_job_factory_;
+  std::unique_ptr<URLRequestJobFactory> test_job_factory_;
 
   TestURLRequestContext context_;
   TestDelegate delegate_;