Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h

Issue 1888813003: [DevTools] Move InjectedScript.lastResult to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
index e05aa97ac1c50085a116f261bb68264b4e4cf4d3..84350fd79f8bae64f2d94cbdf2d988841a6fbfd5 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
@@ -110,7 +110,7 @@ public:
private:
void cleanup();
V8DebuggerImpl::PauseOnExceptionsState setPauseOnExceptionsState(V8DebuggerImpl::PauseOnExceptionsState);
- bool installGlobalObjectExtension(V8FunctionCall&);
+ v8::MaybeLocal<v8::Object> installGlobalObjectExtension(V8FunctionCall&);
v8::HandleScope m_handleScope;
v8::TryCatch m_tryCatch;
@@ -160,12 +160,13 @@ public:
private:
InjectedScript(InspectedContext*, v8::Local<v8::Object>, PassOwnPtr<InjectedScriptNative>);
bool canAccessInspectedWindow() const;
- bool setLastEvaluationResult(ErrorString*, v8::Local<v8::Value>);
+ v8::Local<v8::Value> lastEvaluationResult() const;
v8::Local<v8::Value> v8Value() const;
v8::MaybeLocal<v8::Value> wrapValue(ErrorString*, v8::Local<v8::Value>, const String16& groupName, bool forceValueType, bool generatePreview) const;
InspectedContext* m_context;
v8::Global<v8::Value> m_value;
+ v8::Global<v8::Value> m_lastEvaluationResult;
OwnPtr<InjectedScriptNative> m_native;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698