Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1888533002: Revert of fix getComputedStyle positioned element values (Closed)

Created:
4 years, 8 months ago by Xianzhu
Modified:
4 years, 8 months ago
CC:
chromium-reviews, shans, rjwright, blink-reviews-style_chromium.org, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of fix getComputedStyle positioned element values (patchset #4 id:60001 of https://codereview.chromium.org/1826423003/ ) Reason for revert: Caused crbug.com/602934. BUG=602934, 589347 Original issue's description: > getComputedStyle now returns used values for top, left, bottom, right > > getComputedStyle now returns used values for the top, left, bottom, and > right properties of positioned elements, instead of returning computed > values, if the display property is not None. > > R=mstensho@opera.com > BUG=589347 > > Committed: https://crrev.com/6a2ed97b65b691947eeffbf44ff48a8af2ddff3a > Cr-Commit-Position: refs/heads/master@{#385493} TBR=mstensho@opera.com,rune@opera.com,timloh@chromium.org,khart@codeaurora.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=589347 Committed: https://crrev.com/f119da74988bf022c2dab4193ed289c988d51a26 Cr-Commit-Position: refs/heads/master@{#387068}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -354 lines) Patch
M third_party/WebKit/LayoutTests/animations/animation-properties-in-keyframe-are-ignored.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/animation-properties-in-keyframe-are-ignored-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/change-keyframes.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/play-state.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-resolved-values.html View 1 5 chunks +0 lines, -45 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-resolved-values-expected.txt View 1 21 chunks +0 lines, -220 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/hover-affects-child.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/abspos-dialog-layout.html View 1 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/abspos-dialog-layout-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/fixpos-dialog-layout.html View 1 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/fixpos-dialog-layout-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 chunks +6 lines, -60 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Xianzhu
Created Revert of fix getComputedStyle positioned element values
4 years, 8 months ago (2016-04-13 18:12:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888533002/1
4 years, 8 months ago (2016-04-13 18:12:43 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/18552) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-13 18:16:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888533002/250001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888533002/250001
4 years, 8 months ago (2016-04-13 18:19:37 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:250001)
4 years, 8 months ago (2016-04-13 19:34:22 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f119da74988bf022c2dab4193ed289c988d51a26 Cr-Commit-Position: refs/heads/master@{#387068}
4 years, 8 months ago (2016-04-13 19:36:15 UTC) #10
Xianzhu
4 years, 8 months ago (2016-04-14 05:56:23 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:250001) has been created in
https://codereview.chromium.org/1890743002/ by wangxianzhu@chromium.org.

The reason for reverting is: The bug is actually caused by scripts depending on
old 'auto' value.
Revert the bad revert. Sorry for the noise..

Powered by Google App Engine
This is Rietveld 408576698