third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/fixpos-dialog-layout-expected.txt - Issue 1888533002: Revert of fix getComputedStyle positioned element values

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/fixpos-dialog-layout-expected.txt

Issue 1888533002: Revert of fix getComputedStyle positioned element values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/fixpos-dialog-layout.html ('k') | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 Tests layout of fixed positioned dialogs.	1 Tests layout of fixed positioned dialogs.

2	2

3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

4	4

5	5

6	6

7 showModal() should center in the viewport.	7 showModal() should center in the viewport.

8 PASS dialog.getBoundingClientRect().top is centeredTop	8 PASS dialog.getBoundingClientRect().top is centeredTop

9	9

10 The dialog is a positioned element, so the top and bottom should not have style auto.	10 The computed top and bottom of a centered dialog should still have position auto .

11 PASS window.getComputedStyle(dialog).top is "290px"	11 PASS window.getComputedStyle(dialog).top is "auto"

12 PASS window.getComputedStyle(dialog).bottom is "290px"	12 PASS window.getComputedStyle(dialog).bottom is "auto"

13	13

14 The dialog shold stay centered on scroll.	14 The dialog shold stay centered on scroll.

15 PASS dialog.getBoundingClientRect().top is centeredTop	15 PASS dialog.getBoundingClientRect().top is centeredTop

16	16

17 A tall dialog should be positioned at the top of the viewport.	17 A tall dialog should be positioned at the top of the viewport.

18 PASS dialog.getBoundingClientRect().top is 0	18 PASS dialog.getBoundingClientRect().top is 0

19	19

20 The dialog should be centered regardless of the presence of a horizontal scrollb ar.	20 The dialog should be centered regardless of the presence of a horizontal scrollb ar.

21 PASS dialog.getBoundingClientRect().top is centeredTop	21 PASS dialog.getBoundingClientRect().top is centeredTop

22	22

(...skipping 12 matching lines...) Expand all Loading...
35	35

36 Dialog should not be centered if showModal() was called when an ancestor had dis play 'none'.	36 Dialog should not be centered if showModal() was called when an ancestor had dis play 'none'.

37 FAIL dialog.getBoundingClientRect().top should be 0. Was 10016.	37 FAIL dialog.getBoundingClientRect().top should be 0. Was 10016.

38	38

39 A dialog with specified 'top' should be positioned as usual	39 A dialog with specified 'top' should be positioned as usual

40 PASS dialog.getBoundingClientRect().top is offset	40 PASS dialog.getBoundingClientRect().top is offset

41 PASS successfullyParsed is true	41 PASS successfullyParsed is true

42	42

43 TEST COMPLETE	43 TEST COMPLETE

44	44

OLD	NEW