Remove deprecated paths from image filter infrastructure.

Remove deprecated paths from image filter infrastructure.

Now that there are no filterImageGPUDeprecated() implementations,
we can being to rip out the deprecated infrastructure.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1888243003

Committed: https://skia.googlesource.com/skia/+/6fb3cd7209849e665635ac17ef4eef4ad63e7f61

Committed: https://skia.googlesource.com/skia/+/f35566e8a2497cd7c7bcfeee00c507b3e8ba1587

[Stephen White, 2016-04-15 20:24:03]

Description was changed from

==========
Remove deprecated paths from image filter infrastructure.

Now that there are no filterImageGPUDeprecated() implementations,
we can being to rip out the deprecated infrastructure.

BUG=skia:
==========

to

==========
Remove deprecated paths from image filter infrastructure.

Now that there are no filterImageGPUDeprecated() implementations,
we can being to rip out the deprecated infrastructure.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-04-15 20:27:14]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-15 20:27:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888243003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888243003/20001

[Stephen White, 2016-04-15 20:27:26]

Description was changed from

==========
Remove deprecated paths from image filter infrastructure.

Now that there are no filterImageGPUDeprecated() implementations,
we can being to rip out the deprecated infrastructure.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove deprecated paths from image filter infrastructure.

Now that there are no filterImageGPUDeprecated() implementations,
we can being to rip out the deprecated infrastructure.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-04-15 20:27:26]

senorblanco@chromium.org changed reviewers:
+ robertphillips@google.com

[Stephen White, 2016-04-15 20:28:26]

senorblanco@chromium.org changed reviewers:
+ reed@google.com

[Stephen White, 2016-04-15 20:28:26]

robertphillips: I couldn't resist...

If you'd rather wait until SkColorFilterImageFilter is switched over and/or do
the honours yourself, I'm cool with that.

[reed1, 2016-04-15 20:31:10]

reed@google.com changed required reviewers:
+ robertphillips@google.com

[reed1, 2016-04-15 20:31:10]

api lgtm

[commit-bot: I haz the power, 2016-04-15 20:47:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 20:47:40]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-17 20:51:22]

lgtm

[robertphillips, 2016-04-17 20:51:53]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-04-17 20:51:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888243003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888243003/20001

[commit-bot: I haz the power, 2016-04-17 21:02:08]

Description was changed from

==========
Remove deprecated paths from image filter infrastructure.

Now that there are no filterImageGPUDeprecated() implementations,
we can being to rip out the deprecated infrastructure.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove deprecated paths from image filter infrastructure.

Now that there are no filterImageGPUDeprecated() implementations,
we can being to rip out the deprecated infrastructure.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6fb3cd7209849e665635ac17ef4eef4ad63e7f61
==========

[commit-bot: I haz the power, 2016-04-17 21:02:09]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6fb3cd7209849e665635ac17ef4eef4ad63e7f61

[robertphillips, 2016-04-17 21:31:10]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1893993002/ by robertphillips@google.com.

The reason for reverting is: Surprisingly (appallingly?), Chrome calls
canFilterImageGPU.

[robertphillips, 2016-04-17 21:32:09]

In case the bits rot, here is the compilation error:

../../cc/output/filter_operation.cc:299:47: error: no member named
'canFilterImageGPU' in 'SkImageFilter'
        can_filter_image_gpu = image_filter_->canFilterImageGPU();

[Stephen White, 2016-04-18 17:30:24]

Chrome removal landed as
https://chromium.googlesource.com/chromium/src/+/86649e2861205f8ce4d7099cb83b...;
relanding this.

[Stephen White, 2016-04-18 17:30:33]

Description was changed from

==========
Remove deprecated paths from image filter infrastructure.

Now that there are no filterImageGPUDeprecated() implementations,
we can being to rip out the deprecated infrastructure.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6fb3cd7209849e665635ac17ef4eef4ad63e7f61
==========

to

==========
Remove deprecated paths from image filter infrastructure.

Now that there are no filterImageGPUDeprecated() implementations,
we can being to rip out the deprecated infrastructure.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6fb3cd7209849e665635ac17ef4eef4ad63e7f61
==========

[Stephen White, 2016-04-18 17:30:38]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2016-04-18 17:30:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888243003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888243003/20001

[commit-bot: I haz the power, 2016-04-18 17:32:06]

Description was changed from

==========
Remove deprecated paths from image filter infrastructure.

Now that there are no filterImageGPUDeprecated() implementations,
we can being to rip out the deprecated infrastructure.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6fb3cd7209849e665635ac17ef4eef4ad63e7f61
==========

to

==========
Remove deprecated paths from image filter infrastructure.

Now that there are no filterImageGPUDeprecated() implementations,
we can being to rip out the deprecated infrastructure.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6fb3cd7209849e665635ac17ef4eef4ad63e7f61

Committed:
https://skia.googlesource.com/skia/+/f35566e8a2497cd7c7bcfeee00c507b3e8ba1587
==========

[commit-bot: I haz the power, 2016-04-18 17:32:07]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f35566e8a2497cd7c7bcfeee00c507b3e8ba1587

[f(malita), 2016-04-18 19:18:09]

fmalita@chromium.org changed reviewers:
+ fmalita@chromium.org

[f(malita), 2016-04-18 19:18:10]

Can you take a look at the Win10 failures?  Pretty sure they're related to this
CL (went away on revert, now back):

Failures:
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:124	!cache->get(key1,
&foundOffset)
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:129	!cache->get(key1,
&foundOffset)
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:130	!cache->get(key2,
&foundOffset)
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:124	!cache->get(key1,
&foundOffset)
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:129	!cache->get(key1,
&foundOffset)
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:130	!cache->get(key2,
&foundOffset)
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:124	!cache->get(key1,
&foundOffset)
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:129	!cache->get(key1,
&foundOffset)
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:130	!cache->get(key2,
&foundOffset)
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:124	!cache->get(key1,
&foundOffset)
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:129	!cache->get(key1,
&foundOffset)
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:130	!cache->get(key2,
&foundOffset)
12 failures
step returned non-zero exit code: 1

https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Win10-MSVC-S...

[Stephen White, 2016-04-18 19:44:45]

On 2016/04/18 19:18:10, f(malita) wrote:
> Can you take a look at the Win10 failures?  Pretty sure they're related to
this
> CL (went away on revert, now back):
> 
> Failures:
>
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:124	!cache->get(key1,
> &foundOffset)
>
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:129	!cache->get(key1,
> &foundOffset)
>
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:130	!cache->get(key2,
> &foundOffset)
>
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:124	!cache->get(key1,
> &foundOffset)
>
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:129	!cache->get(key1,
> &foundOffset)
>
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:130	!cache->get(key2,
> &foundOffset)
>
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:124	!cache->get(key1,
> &foundOffset)
>
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:129	!cache->get(key1,
> &foundOffset)
>
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:130	!cache->get(key2,
> &foundOffset)
>
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:124	!cache->get(key1,
> &foundOffset)
>
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:129	!cache->get(key1,
> &foundOffset)
>
	c:\0\build\slave\workdir\build\skia\tests\imagefiltercachetest.cpp:130	!cache->get(key2,
> &foundOffset)
> 12 failures
> step returned non-zero exit code: 1
> 
>
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Win10-MSVC-S...

That is really weird. I have no clue how this could be failing only on Win10,
unless it's something weird
in the SkAutoMutex stuff on Windows. (Which seems unlikely, given that this test
is single-threaded code.)


Rob, any ideas?