Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1887303003:
Build: disable icf for gcc builds with bundled gold (Closed)
|
Created:
4 years, 8 months ago by Lukasz Jagielski Modified:
4 years, 8 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBuild: disable icf for gcc builds with bundled gold
Gold doesn't respect section alignment when merging symbols
https://sourceware.org/bugzilla/show_bug.cgi?id=17704
BUG=576197
Committed: https://crrev.com/feea41a011671a28dd15e2bb1d1290d817d601c0
Cr-Commit-Position: refs/heads/master@{#388437}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Fixup #
Messages
Total messages: 20 (8 generated)
Description was changed from ========== Build: disable icf for gcc builds with bundled gold Gold doesn't respect section alignment when merging symbols https://sourceware.org/bugzilla/show_bug.cgi?id=17704 BUG=576197 ========== to ========== Build: disable icf for gcc builds with bundled gold Gold doesn't respect section alignment when merging symbols https://sourceware.org/bugzilla/show_bug.cgi?id=17704 BUG=576197 ==========
ljagielski@opera.com changed reviewers: + dpranke@chromium.org
Hi, PTAL at my CL proposition. Regards, Łukasz
dpranke@chromium.org changed reviewers: + mcgrathr@chromium.org
+mcgrathr to double-check this ... https://codereview.chromium.org/1887303003/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/1887303003/diff/1/build/config/compiler/BUILD... build/config/compiler/BUILD.gn:116: gold_icf_level = "all" I think you need to actually use this, also? I don't see any other reference to a gold_icf_level in the GN buildfiles, so it might still need to be ported.
https://codereview.chromium.org/1887303003/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/1887303003/diff/1/build/config/compiler/BUILD... build/config/compiler/BUILD.gn:321: ldflags += [ "-Wl,--icf=all" ] This line is what needs to be changed to use $gold_icf_level.
https://codereview.chromium.org/1887303003/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/1887303003/diff/1/build/config/compiler/BUILD... build/config/compiler/BUILD.gn:116: gold_icf_level = "all" On 2016/04/15 21:20:55, Dirk Pranke wrote: > I think you need to actually use this, also? I don't see any other reference to > a gold_icf_level in the GN buildfiles, so it might still need to be ported. Done. https://codereview.chromium.org/1887303003/diff/1/build/config/compiler/BUILD... build/config/compiler/BUILD.gn:321: ldflags += [ "-Wl,--icf=all" ] On 2016/04/15 21:24:49, Roland McGrath wrote: > This line is what needs to be changed to use $gold_icf_level. Yeah, I had this but made a mistake when I was moving patch from different repo.
lgtm
The CQ bit was checked by ljagielski@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887303003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by ljagielski@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887303003/20001
Message was sent while issue was closed.
Description was changed from ========== Build: disable icf for gcc builds with bundled gold Gold doesn't respect section alignment when merging symbols https://sourceware.org/bugzilla/show_bug.cgi?id=17704 BUG=576197 ========== to ========== Build: disable icf for gcc builds with bundled gold Gold doesn't respect section alignment when merging symbols https://sourceware.org/bugzilla/show_bug.cgi?id=17704 BUG=576197 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Build: disable icf for gcc builds with bundled gold Gold doesn't respect section alignment when merging symbols https://sourceware.org/bugzilla/show_bug.cgi?id=17704 BUG=576197 ========== to ========== Build: disable icf for gcc builds with bundled gold Gold doesn't respect section alignment when merging symbols https://sourceware.org/bugzilla/show_bug.cgi?id=17704 BUG=576197 Committed: https://crrev.com/feea41a011671a28dd15e2bb1d1290d817d601c0 Cr-Commit-Position: refs/heads/master@{#388437} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/feea41a011671a28dd15e2bb1d1290d817d601c0 Cr-Commit-Position: refs/heads/master@{#388437}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1930473002/ by pasko@chromium.org. The reason for reverting is: Seems to be causing a 2.5MiB regression in libchrome.so on Android/ARM. Please re-land with disabling ICF for Linux-only. See: crbug.com/605494. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
