Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Unified Diff: build/common.gypi

Issue 1887303003: Build: disable icf for gcc builds with bundled gold (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixup Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 2f5025a54bc01988eb845c9ea7fdf04131adee68..49b6784af6c2dd45d8e4849089e4eee2611bebe2 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2486,6 +2486,12 @@
}, {
'enable_hangout_services_extension%': 0,
}],
+
+ # Gold doesn't respect section alignment and breaks gcc builds with icf
+ # https://bugs.chromium.org/p/chromium/issues/detail?id=576197
+ ['clang==0 and linux_use_bundled_gold==1', {
+ 'gold_icf_level%': 'none'
+ }],
],
# The path to the ANGLE library.
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698