Removing unused field - AppCacheResponseIO::group_id_.

Removing unused field - AppCacheResponseIO::group_id_.

Removing the unused field allows cascading removals of other code that used to
pass group id value around (but not actually using the value).

BUG=600434
Committed: https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b
Cr-Commit-Position: refs/heads/master@{#388343}

[Łukasz Anforowicz, 2016-04-14 19:27:05]

lukasza@chromium.org changed reviewers:
+ michaeln@chromium.org

[Łukasz Anforowicz, 2016-04-14 19:27:06]

michaeln@, could you please check if it is okay to remove
AppCacheResponseIO::group_id_ field (it seems unused)?

In particular nick@ wanted [1] to make sure that:

> I want to make sure that the fact that the code doesn't reference group_id
isn't
> a bug that ought to be fixed (Being unfamiliar with this code, I don't know
> whether group_id is some kind of security principal that needs to be validated
> for access rights, or what)

PS. This CL has been extracted out of a bigger CL
(https://codereview.chromium.org/1875463002/) that tries to remove unused fields
(as identified by Scythe - go/scythe, Googlers only :-/ ).

PPS. Scythe highlighted as unused and removed AppCacheResponseIO::group_id_
field.  Other changes are a manual follow-up that created cascading removals
(i.e. if group_id parameter is not needed after field removal, let's remove the
parameter and arguments from the callers;  rinse and repeat).  OTOH, I don't
claim that the cascading changes are complete - it is possible that subsequent
Scythe invocations will highlight fields and/or functions that have become
unused after this CL.

[1] https://codereview.chromium.org/1875463002/patch/270001/280002

[michaeln, 2016-04-19 20:46:24]

lgtm

(of archaeological interest only, way back when, this value was plumbed along to
leave open the possibility of storing each group's resources in a separate
diskcache instance)

[Łukasz Anforowicz, 2016-04-19 21:51:00]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-04-19 21:51:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887153002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887153002/40001

[commit-bot: I haz the power, 2016-04-19 23:00:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:17:35]

Description was changed from

==========
Removing unused field - AppCacheResponseIO::group_id_.

Removing the unused field allows cascading removals of other code that used to
pass group id value around (but not actually using the value).

BUG=600434
==========

to

==========
Removing unused field - AppCacheResponseIO::group_id_.

Removing the unused field allows cascading removals of other code that used to
pass group id value around (but not actually using the value).

BUG=600434

Committed: https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b
Cr-Commit-Position: refs/heads/master@{#388343}
==========

[commit-bot: I haz the power, 2016-04-22 19:17:36]

Patchset 3 (id:??) landed as
https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b
Cr-Commit-Position: refs/heads/master@{#388343}