Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1991)

Unified Diff: content/browser/appcache/appcache_storage.cc

Issue 1887153002: Removing unused field - AppCacheResponseIO::group_id_. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl format Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/appcache/appcache_storage.h ('k') | content/browser/appcache/appcache_storage_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_storage.cc
diff --git a/content/browser/appcache/appcache_storage.cc b/content/browser/appcache/appcache_storage.cc
index 7b94bf44965b3c6374f6415f23691fc0a9e8d631..b710ea268ddacfdd6dac1f374b3b6f4381cd3788 100644
--- a/content/browser/appcache/appcache_storage.cc
+++ b/content/browser/appcache/appcache_storage.cc
@@ -41,12 +41,10 @@ AppCacheStorage::DelegateReference::~DelegateReference() {
AppCacheStorage::ResponseInfoLoadTask::ResponseInfoLoadTask(
const GURL& manifest_url,
- int64_t group_id,
int64_t response_id,
AppCacheStorage* storage)
: storage_(storage),
manifest_url_(manifest_url),
- group_id_(group_id),
response_id_(response_id),
info_buffer_(new HttpResponseInfoIOBuffer) {
storage_->pending_info_loads_.insert(
@@ -59,8 +57,7 @@ AppCacheStorage::ResponseInfoLoadTask::~ResponseInfoLoadTask() {
void AppCacheStorage::ResponseInfoLoadTask::StartIfNeeded() {
if (reader_)
return;
- reader_.reset(
- storage_->CreateResponseReader(manifest_url_, group_id_, response_id_));
+ reader_.reset(storage_->CreateResponseReader(manifest_url_, response_id_));
reader_->ReadInfo(info_buffer_.get(),
base::Bind(&ResponseInfoLoadTask::OnReadComplete,
base::Unretained(this)));
@@ -80,7 +77,6 @@ void AppCacheStorage::ResponseInfoLoadTask::OnReadComplete(int result) {
}
void AppCacheStorage::LoadResponseInfo(const GURL& manifest_url,
- int64_t group_id,
int64_t id,
Delegate* delegate) {
AppCacheResponseInfo* info = working_set_.GetResponseInfo(id);
@@ -89,9 +85,8 @@ void AppCacheStorage::LoadResponseInfo(const GURL& manifest_url,
return;
}
ResponseInfoLoadTask* info_load =
- GetOrCreateResponseInfoLoadTask(manifest_url, group_id, id);
+ GetOrCreateResponseInfoLoadTask(manifest_url, id);
DCHECK(manifest_url == info_load->manifest_url());
- DCHECK(group_id == info_load->group_id());
DCHECK(id == info_load->response_id());
info_load->AddDelegate(GetOrCreateDelegateReference(delegate));
info_load->StartIfNeeded();
« no previous file with comments | « content/browser/appcache/appcache_storage.h ('k') | content/browser/appcache/appcache_storage_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698