Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: content/browser/appcache/appcache_storage.cc

Issue 1887153002: Removing unused field - AppCacheResponseIO::group_id_. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl format Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/appcache/appcache_storage.h" 5 #include "content/browser/appcache/appcache_storage.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "content/browser/appcache/appcache_response.h" 10 #include "content/browser/appcache/appcache_response.h"
(...skipping 23 matching lines...) Expand all
34 DelegateReferenceMap::value_type(delegate, this)); 34 DelegateReferenceMap::value_type(delegate, this));
35 } 35 }
36 36
37 AppCacheStorage::DelegateReference::~DelegateReference() { 37 AppCacheStorage::DelegateReference::~DelegateReference() {
38 if (delegate) 38 if (delegate)
39 storage->delegate_references_.erase(delegate); 39 storage->delegate_references_.erase(delegate);
40 } 40 }
41 41
42 AppCacheStorage::ResponseInfoLoadTask::ResponseInfoLoadTask( 42 AppCacheStorage::ResponseInfoLoadTask::ResponseInfoLoadTask(
43 const GURL& manifest_url, 43 const GURL& manifest_url,
44 int64_t group_id,
45 int64_t response_id, 44 int64_t response_id,
46 AppCacheStorage* storage) 45 AppCacheStorage* storage)
47 : storage_(storage), 46 : storage_(storage),
48 manifest_url_(manifest_url), 47 manifest_url_(manifest_url),
49 group_id_(group_id),
50 response_id_(response_id), 48 response_id_(response_id),
51 info_buffer_(new HttpResponseInfoIOBuffer) { 49 info_buffer_(new HttpResponseInfoIOBuffer) {
52 storage_->pending_info_loads_.insert( 50 storage_->pending_info_loads_.insert(
53 PendingResponseInfoLoads::value_type(response_id, this)); 51 PendingResponseInfoLoads::value_type(response_id, this));
54 } 52 }
55 53
56 AppCacheStorage::ResponseInfoLoadTask::~ResponseInfoLoadTask() { 54 AppCacheStorage::ResponseInfoLoadTask::~ResponseInfoLoadTask() {
57 } 55 }
58 56
59 void AppCacheStorage::ResponseInfoLoadTask::StartIfNeeded() { 57 void AppCacheStorage::ResponseInfoLoadTask::StartIfNeeded() {
60 if (reader_) 58 if (reader_)
61 return; 59 return;
62 reader_.reset( 60 reader_.reset(storage_->CreateResponseReader(manifest_url_, response_id_));
63 storage_->CreateResponseReader(manifest_url_, group_id_, response_id_));
64 reader_->ReadInfo(info_buffer_.get(), 61 reader_->ReadInfo(info_buffer_.get(),
65 base::Bind(&ResponseInfoLoadTask::OnReadComplete, 62 base::Bind(&ResponseInfoLoadTask::OnReadComplete,
66 base::Unretained(this))); 63 base::Unretained(this)));
67 } 64 }
68 65
69 void AppCacheStorage::ResponseInfoLoadTask::OnReadComplete(int result) { 66 void AppCacheStorage::ResponseInfoLoadTask::OnReadComplete(int result) {
70 storage_->pending_info_loads_.erase(response_id_); 67 storage_->pending_info_loads_.erase(response_id_);
71 scoped_refptr<AppCacheResponseInfo> info; 68 scoped_refptr<AppCacheResponseInfo> info;
72 if (result >= 0) { 69 if (result >= 0) {
73 info = new AppCacheResponseInfo(storage_, manifest_url_, 70 info = new AppCacheResponseInfo(storage_, manifest_url_,
74 response_id_, 71 response_id_,
75 info_buffer_->http_info.release(), 72 info_buffer_->http_info.release(),
76 info_buffer_->response_data_size); 73 info_buffer_->response_data_size);
77 } 74 }
78 FOR_EACH_DELEGATE(delegates_, OnResponseInfoLoaded(info.get(), response_id_)); 75 FOR_EACH_DELEGATE(delegates_, OnResponseInfoLoaded(info.get(), response_id_));
79 delete this; 76 delete this;
80 } 77 }
81 78
82 void AppCacheStorage::LoadResponseInfo(const GURL& manifest_url, 79 void AppCacheStorage::LoadResponseInfo(const GURL& manifest_url,
83 int64_t group_id,
84 int64_t id, 80 int64_t id,
85 Delegate* delegate) { 81 Delegate* delegate) {
86 AppCacheResponseInfo* info = working_set_.GetResponseInfo(id); 82 AppCacheResponseInfo* info = working_set_.GetResponseInfo(id);
87 if (info) { 83 if (info) {
88 delegate->OnResponseInfoLoaded(info, id); 84 delegate->OnResponseInfoLoaded(info, id);
89 return; 85 return;
90 } 86 }
91 ResponseInfoLoadTask* info_load = 87 ResponseInfoLoadTask* info_load =
92 GetOrCreateResponseInfoLoadTask(manifest_url, group_id, id); 88 GetOrCreateResponseInfoLoadTask(manifest_url, id);
93 DCHECK(manifest_url == info_load->manifest_url()); 89 DCHECK(manifest_url == info_load->manifest_url());
94 DCHECK(group_id == info_load->group_id());
95 DCHECK(id == info_load->response_id()); 90 DCHECK(id == info_load->response_id());
96 info_load->AddDelegate(GetOrCreateDelegateReference(delegate)); 91 info_load->AddDelegate(GetOrCreateDelegateReference(delegate));
97 info_load->StartIfNeeded(); 92 info_load->StartIfNeeded();
98 } 93 }
99 94
100 void AppCacheStorage::UpdateUsageMapAndNotify(const GURL& origin, 95 void AppCacheStorage::UpdateUsageMapAndNotify(const GURL& origin,
101 int64_t new_usage) { 96 int64_t new_usage) {
102 DCHECK_GE(new_usage, 0); 97 DCHECK_GE(new_usage, 0);
103 int64_t old_usage = usage_map_[origin]; 98 int64_t old_usage = usage_map_[origin];
104 if (new_usage > 0) 99 if (new_usage > 0)
(...skipping 27 matching lines...) Expand all
132 if (service()->quota_manager_proxy() && 127 if (service()->quota_manager_proxy() &&
133 usage_map_.find(origin) != usage_map_.end()) 128 usage_map_.find(origin) != usage_map_.end())
134 service()->quota_manager_proxy()->NotifyStorageAccessed( 129 service()->quota_manager_proxy()->NotifyStorageAccessed(
135 storage::QuotaClient::kAppcache, 130 storage::QuotaClient::kAppcache,
136 origin, 131 origin,
137 storage::kStorageTypeTemporary); 132 storage::kStorageTypeTemporary);
138 } 133 }
139 134
140 } // namespace content 135 } // namespace content
141 136
OLDNEW
« no previous file with comments | « content/browser/appcache/appcache_storage.h ('k') | content/browser/appcache/appcache_storage_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698