Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1886953002: Add OpenTypeCapsSupport class (Closed)

Created:
4 years, 8 months ago by drott
Modified:
4 years, 8 months ago
Reviewers:
kojii, eae, behdad
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add OpenTypeCapsSupport class As preparation for implementing correct font-variant-caps we need to be able to check font files for their ability to support caps related OpenType features, such as 'smcp', 'c2sc' etc. The implementation files are split in two, one part Chromium-side implementation, one part Mozilla Public License'd code adapted from Firefox. Relanding this after revert in https://codereview.chromium.org/1891613002/ due to broken blink_platform_unittests. Splitting out the test into a separate CL in order to investigate a possible swarming/isolate step issue. BUG=587094 TEST=OpenTypeCapsSupportTest.cpp Committed: https://crrev.com/15a403b49955e66c4b3abb8f3f93c5426d7923b1 Cr-Commit-Position: refs/heads/master@{#387256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDescription.h View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupport.h View 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupport.cpp View 1 chunk +173 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp View 1 chunk +81 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
drott
kojii@, could you review this? This would be helpful, so that I can continue landing ...
4 years, 8 months ago (2016-04-14 06:25:21 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886953002/1
4 years, 8 months ago (2016-04-14 06:25:47 UTC) #4
kojii
lgtm, hope this sticks this time ;)
4 years, 8 months ago (2016-04-14 06:54:26 UTC) #5
kojii
lgtm, hope this sticks this time ;)
4 years, 8 months ago (2016-04-14 06:54:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886953002/1
4 years, 8 months ago (2016-04-14 07:00:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 07:44:32 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 07:45:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15a403b49955e66c4b3abb8f3f93c5426d7923b1
Cr-Commit-Position: refs/heads/master@{#387256}

Powered by Google App Engine
This is Rietveld 408576698