Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1885963005: Add test case for OpenTypeCapsSupport (Closed)

Created:
4 years, 8 months ago by drott
Modified:
4 years, 8 months ago
Reviewers:
kojii, eae
CC:
Dirk Pranke, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@openTypeCapsSupportNoTest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test case for OpenTypeCapsSupport This adds the test separately, after previous attempts to land this had failed with issues in the swarming/isolate setup, see https://codereview.chromium.org/1891613002/ . Landing this separately will help us analyse why files are not available in the swarming step of running blink_platform_unittests or what the root cause is. BUG=587094 R=eae,kojii Committed: https://crrev.com/51428c9a0c963278a185d007af34c0d68f57e762 Cr-Commit-Position: refs/heads/master@{#387267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform_unittests.isolate View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp View 1 chunk +113 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (6 generated)
drott
4 years, 8 months ago (2016-04-14 06:33:05 UTC) #1
drott
4 years, 8 months ago (2016-04-14 06:33:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885963005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885963005/1
4 years, 8 months ago (2016-04-14 06:33:54 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 07:44:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885963005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885963005/1
4 years, 8 months ago (2016-04-14 08:41:21 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-14 08:41:23 UTC) #10
kojii
lgtm
4 years, 8 months ago (2016-04-14 08:50:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885963005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885963005/1
4 years, 8 months ago (2016-04-14 08:51:59 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 08:57:10 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/51428c9a0c963278a185d007af34c0d68f57e762 Cr-Commit-Position: refs/heads/master@{#387267}
4 years, 8 months ago (2016-04-14 08:58:17 UTC) #16
drott
4 years, 8 months ago (2016-04-14 12:25:15 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1889813002/ by drott@chromium.org.

The reason for reverting is: Breaks blink_platform unittests on Linux:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux.

Powered by Google App Engine
This is Rietveld 408576698