Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1891613002: Revert of Add OpenTypeCapsSupport class (Closed)

Created:
4 years, 8 months ago by rjkroege
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, behdad, kojii, eae, drott
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@caseMapHbBufferFillerLand
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add OpenTypeCapsSupport class (patchset #3 id:40001 of https://codereview.chromium.org/1882063002/ ) Reason for revert: breaks layout tests on Linux 6 tests crashed: OpenTypeCapsSupportTest.LibertineAllPetiteSynthesis (../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:53) OpenTypeCapsSupportTest.LibertineIgnoreMissingTitling (../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:38) OpenTypeCapsSupportTest.LibertineSmcpC2scSupported (../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:23) OpenTypeCapsSupportTest.LibertineUnicaseFallback (../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:98) OpenTypeCapsSupportTest.MEgalopolisSmallCapsSynthetic (../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:68) OpenTypeCapsSupportTest.MEgalopolisUnicaseSynthetic (../../third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp:83) Original issue's description: > Add OpenTypeCapsSupport class > > As preparation for implementing correct font-variant-caps we need to be > able to check font files for their ability to support caps related > OpenType features, such as 'smcp', 'c2sc' etc. > > The implementation files are split in two, one part Chromium-side > implementation, one part Mozilla Public License'd code adapted from > Firefox. > > BUG=587094 > TEST=OpenTypeCapsSupportTest.cpp > TBR=dpranke > > Committed: https://crrev.com/530c73184ff5fed64d9dae5ff1d452d1a75d3a99 > Cr-Commit-Position: refs/heads/master@{#387085} TBR=behdad@chromium.org,dpranke@chromium.org,eae@chromium.org,kojii@chromium.org,drott@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587094 Committed: https://crrev.com/3725b50a27ae6ba927cd0cd0e6d79eae86d9bf73 Cr-Commit-Position: refs/heads/master@{#387119}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
rjkroege
Created Revert of Add OpenTypeCapsSupport class
4 years, 8 months ago (2016-04-13 22:14:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891613002/1
4 years, 8 months ago (2016-04-13 22:15:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 22:17:25 UTC) #4
Dirk Pranke
lgtm, thanks!
4 years, 8 months ago (2016-04-13 22:18:20 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 22:19:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3725b50a27ae6ba927cd0cd0e6d79eae86d9bf73
Cr-Commit-Position: refs/heads/master@{#387119}

Powered by Google App Engine
This is Rietveld 408576698