Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1886903003: Workaround for VC++ 2015 Update 2 code-gen bug (Closed)

Created:
4 years, 8 months ago by brucedawson
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Workaround for VC++ 2015 Update 2 code-gen bug The xsl transformation function 'translate' was broken by VS 2015 due to a code-gen bug, reported to Microsoft as: https://connect.microsoft.com/VisualStudio/feedback/details/2582138 The simplest workaround is to optimize for time instead of size in the affected function. TEST=Go to https://jsfiddle.net/9r1nLumk/1/ and confirm that the output is "Simple_sting_line" BUG=599427 Review URL: https://codereview.chromium.org/1878963005 Cr-Commit-Position: refs/heads/master@{#386890} (cherry picked from commit 81e7bce94d50b04b1c1119e0fe460396dd1302fe) Committed: https://chromium.googlesource.com/chromium/src/+/8a902bf6f6601e665e9ef656176f5497bdc06d97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/libxml/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libxml/src/xmlstring.c View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
brucedawson
4 years, 8 months ago (2016-04-14 21:08:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a902bf6f6601e665e9ef656176f5497bdc06d97.

Powered by Google App Engine
This is Rietveld 408576698