Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1878963005: Workaround for VC++ 2015 Update 2 code-gen bug (Closed)

Created:
4 years, 8 months ago by brucedawson
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Workaround for VC++ 2015 Update 2 code-gen bug The xsl transformation function 'translate' was broken by VS 2015 due to a code-gen bug, reported to Microsoft as: https://connect.microsoft.com/VisualStudio/feedback/details/2582138 The simplest workaround is to optimize for time instead of size in the affected function. TEST=Go to https://jsfiddle.net/9r1nLumk/1/ and confirm that the output is "Simple_sting_line" BUG=599427 Committed: https://crrev.com/81e7bce94d50b04b1c1119e0fe460396dd1302fe Cr-Commit-Position: refs/heads/master@{#386890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/libxml/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libxml/src/xmlstring.c View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brucedawson
PTAL - and let me know if there is a good place to put a ...
4 years, 8 months ago (2016-04-12 23:50:57 UTC) #2
scottmg
lgtm, please try to add a Blink layout test that rolls up that jsfiddle.
4 years, 8 months ago (2016-04-13 00:01:46 UTC) #4
brucedawson
On 2016/04/13 00:01:46, scottmg wrote: > lgtm, please try to add a Blink layout test ...
4 years, 8 months ago (2016-04-13 00:27:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1878963005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1878963005/1
4 years, 8 months ago (2016-04-13 00:27:58 UTC) #7
dominicc (has gone to gerrit)
lgtm
4 years, 8 months ago (2016-04-13 00:30:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 01:40:54 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 01:46:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81e7bce94d50b04b1c1119e0fe460396dd1302fe
Cr-Commit-Position: refs/heads/master@{#386890}

Powered by Google App Engine
This is Rietveld 408576698