Speech: remove GoogleOneShotRemoteEngine

Speech: remove GoogleOneShotRemoteEngine

This was used by the legacy x-webkit-input-speech API which is now long gone.

BUG=223198
TBR=jam

Committed: https://crrev.com/fa81aea7ef50d7bf459086028c34d7df813c92f4
Cr-Commit-Position: refs/heads/master@{#387352}

[hans, 2016-04-13 17:24:14]

hans@chromium.org changed reviewers:
+ primiano@chromium.org, tommi@chromium.org

[hans, 2016-04-13 17:24:14]

Please take a look.

[Primiano Tucci (use gerrit), 2016-04-13 17:50:05]

oh wow, I spoke too early in my other codereview.
Awesome, LGTM, just one doubt about build files.

https://codereview.chromium.org/1886813002/diff/1/content/browser/speech/spee...
File content/browser/speech/speech_recognizer_impl_unittest.cc (right):

https://codereview.chromium.org/1886813002/diff/1/content/browser/speech/spee...
content/browser/speech/speech_recognizer_impl_unittest.cc:13: #include
"content/browser/speech/proto/google_streaming_api.pb.h"
Just checking: does this require now a dependency from content_unittest to the
speech/proto target? Or that is already there via some test_support target?

[hans, 2016-04-13 17:55:41]

https://codereview.chromium.org/1886813002/diff/1/content/browser/speech/spee...
File content/browser/speech/speech_recognizer_impl_unittest.cc (right):

https://codereview.chromium.org/1886813002/diff/1/content/browser/speech/spee...
content/browser/speech/speech_recognizer_impl_unittest.cc:13: #include
"content/browser/speech/proto/google_streaming_api.pb.h"
On 2016/04/13 17:50:05, Primiano Tucci wrote:
> Just checking: does this require now a dependency from content_unittest to the
> speech/proto target? Or that is already there via some test_support target?

The dependency is already there because of
content/browser/speech/google_streaming_remote_engine_unittest.cc

[Primiano Tucci (use gerrit), 2016-04-13 17:56:53]

On 2016/04/13 17:55:41, hans wrote:
>
https://codereview.chromium.org/1886813002/diff/1/content/browser/speech/spee...
> File content/browser/speech/speech_recognizer_impl_unittest.cc (right):
> 
>
https://codereview.chromium.org/1886813002/diff/1/content/browser/speech/spee...
> content/browser/speech/speech_recognizer_impl_unittest.cc:13: #include
> "content/browser/speech/proto/google_streaming_api.pb.h"
> On 2016/04/13 17:50:05, Primiano Tucci wrote:
> > Just checking: does this require now a dependency from content_unittest to
the
> > speech/proto target? Or that is already there via some test_support target?
> 
> The dependency is already there because of
> content/browser/speech/google_streaming_remote_engine_unittest.cc

Right, just found it: it's in content/test_support
https://code.google.com/p/chromium/codesearch#chromium/src/content/test/BUILD...

[tommi (sloooow) - chröme, 2016-04-14 14:22:42]

lgtm

[hans, 2016-04-14 16:48:20]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2016-04-14 16:48:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886813002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886813002/1

[commit-bot: I haz the power, 2016-04-14 16:59:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 16:59:05]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hans, 2016-04-14 17:04:57]

Description was changed from

==========
Speech: remove GoogleOneShotRemoteEngine

This was used by the legacy x-webkit-input-speech API which is now long gone.

BUG=223198
==========

to

==========
Speech: remove GoogleOneShotRemoteEngine

This was used by the legacy x-webkit-input-speech API which is now long gone.

BUG=223198
TBR=dpranke
==========

[hans, 2016-04-14 17:05:47]

hans@chromium.org changed reviewers:
+ dpranke@chromium.org

[hans, 2016-04-14 17:05:48]

tbr dpranke for trivial content/browser/BUILD.gn change

[hans, 2016-04-14 17:05:55]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2016-04-14 17:06:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886813002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886813002/1

[Dirk Pranke, 2016-04-14 17:21:26]

lgtm, though I'm not an owner . tbr'ing jam@ who is ...

[Dirk Pranke, 2016-04-14 17:21:47]

Description was changed from

==========
Speech: remove GoogleOneShotRemoteEngine

This was used by the legacy x-webkit-input-speech API which is now long gone.

BUG=223198
TBR=dpranke
==========

to

==========
Speech: remove GoogleOneShotRemoteEngine

This was used by the legacy x-webkit-input-speech API which is now long gone.

BUG=223198
TBR=jam
==========

[Dirk Pranke, 2016-04-14 17:21:47]

dpranke@chromium.org changed reviewers:
+ jam@chromium.org

[commit-bot: I haz the power, 2016-04-14 17:41:53]

Description was changed from

==========
Speech: remove GoogleOneShotRemoteEngine

This was used by the legacy x-webkit-input-speech API which is now long gone.

BUG=223198
TBR=jam
==========

to

==========
Speech: remove GoogleOneShotRemoteEngine

This was used by the legacy x-webkit-input-speech API which is now long gone.

BUG=223198
TBR=jam
==========

[commit-bot: I haz the power, 2016-04-14 17:41:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-14 17:43:20]

Description was changed from

==========
Speech: remove GoogleOneShotRemoteEngine

This was used by the legacy x-webkit-input-speech API which is now long gone.

BUG=223198
TBR=jam
==========

to

==========
Speech: remove GoogleOneShotRemoteEngine

This was used by the legacy x-webkit-input-speech API which is now long gone.

BUG=223198
TBR=jam

Committed: https://crrev.com/fa81aea7ef50d7bf459086028c34d7df813c92f4
Cr-Commit-Position: refs/heads/master@{#387352}
==========

[commit-bot: I haz the power, 2016-04-14 17:43:21]

Patchset 1 (id:??) landed as
https://crrev.com/fa81aea7ef50d7bf459086028c34d7df813c92f4
Cr-Commit-Position: refs/heads/master@{#387352}