Remove SpeechRecognitionSessionConfig::is_legacy_api

Remove SpeechRecognitionSessionConfig::is_legacy_api

The legacy API was removed some time ago.

BUG=223198
Committed: https://crrev.com/2b140bf325026fea868b715c03716f5e2d343735
Cr-Commit-Position: refs/heads/master@{#387337}

[hans, 2016-04-13 17:23:15]

hans@chromium.org changed reviewers:
+ primiano@chromium.org, tommi@chromium.org

[hans, 2016-04-13 17:23:16]

Please take a look.

[hans, 2016-04-13 17:24:51]

The CQ bit was checked by hans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 17:25:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1889523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1889523002/1

[Primiano Tucci (use gerrit), 2016-04-13 17:40:59]

Aaaa, dejavus from my first steps in chromium.
Our good old times :)

LGTM thanks for the cleanup!

https://codereview.chromium.org/1889523002/diff/1/content/browser/speech/spee...
File content/browser/speech/speech_recognition_manager_impl.cc (left):

https://codereview.chromium.org/1889523002/diff/1/content/browser/speech/spee...
content/browser/speech/speech_recognition_manager_impl.cc:147: new
GoogleOneShotRemoteEngine(config.url_request_context_getter.get());
At this point in theory we could remove the GoogleOneShotRemoteEngine.
In practice IIRC that is still used by the recognizer unittest, so might not be
that easy. :)

[hans, 2016-04-13 17:41:50]

https://codereview.chromium.org/1889523002/diff/1/content/browser/speech/spee...
File content/browser/speech/speech_recognition_manager_impl.cc (left):

https://codereview.chromium.org/1889523002/diff/1/content/browser/speech/spee...
content/browser/speech/speech_recognition_manager_impl.cc:147: new
GoogleOneShotRemoteEngine(config.url_request_context_getter.get());
On 2016/04/13 17:40:59, Primiano Tucci wrote:
> At this point in theory we could remove the GoogleOneShotRemoteEngine.
> In practice IIRC that is still used by the recognizer unittest, so might not
be
> that easy. :)

I have a CL for that :-) https://codereview.chromium.org/1886813002

[commit-bot: I haz the power, 2016-04-13 18:25:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 18:25:57]

Dry run: This issue passed the CQ dry run.

[tommi (sloooow) - chröme, 2016-04-14 14:21:23]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2016-04-14 14:21:24]

lgtm

[commit-bot: I haz the power, 2016-04-14 14:21:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1889523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1889523002/1

[commit-bot: I haz the power, 2016-04-14 14:30:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 14:30:47]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hans, 2016-04-14 15:08:35]

hans@chromium.org changed reviewers:
+ piman@chromium.org, thakis@chromium.org

[hans, 2016-04-14 15:08:35]

+piman for content/
+thakis for chrome/

Please provide owners' stamps.

[Nico, 2016-04-14 15:14:09]

lgtm

[jochen (gone - plz use gerrit), 2016-04-14 16:38:41]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-04-14 16:38:41]

lgtm

[hans, 2016-04-14 16:39:00]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2016-04-14 16:39:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1889523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1889523002/1

[commit-bot: I haz the power, 2016-04-14 16:44:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-14 16:45:48]

Description was changed from

==========
Remove SpeechRecognitionSessionConfig::is_legacy_api

The legacy API was removed some time ago.

BUG=223198
==========

to

==========
Remove SpeechRecognitionSessionConfig::is_legacy_api

The legacy API was removed some time ago.

BUG=223198

Committed: https://crrev.com/2b140bf325026fea868b715c03716f5e2d343735
Cr-Commit-Position: refs/heads/master@{#387337}
==========

[commit-bot: I haz the power, 2016-04-14 16:45:49]

Patchset 1 (id:??) landed as
https://crrev.com/2b140bf325026fea868b715c03716f5e2d343735
Cr-Commit-Position: refs/heads/master@{#387337}