Devirtualize SpeechRecognitionEngine

Devirtualize SpeechRecognitionEngine

Now that there is only one implementation of SpeechRecognitionEngine, make that
class concrete.

BUG=223198
TBR=jam

Committed: https://crrev.com/18b756f93a5bd8a8ec402f5542905e2a7296987d
Cr-Commit-Position: refs/heads/master@{#387374}

[hans, 2016-04-13 21:23:05]

hans@chromium.org changed reviewers:
+ primiano@chromium.org, tommi@chromium.org

[hans, 2016-04-13 21:23:06]

Please take a look.

https://codereview.chromium.org/1891543002/diff/20001/content/browser/speech/...
File content/browser/speech/speech_recognition_engine.h (left):

https://codereview.chromium.org/1891543002/diff/20001/content/browser/speech/...
content/browser/speech/speech_recognition_engine.h:114: typedef
SpeechRecognitionEngine::Config SpeechRecognitionEngineConfig;
Let's see if current MSVC can do without these..

[hans, 2016-04-13 21:23:19]

Description was changed from

==========
Devirtualize SpeechRecognitionEngine

Now that there is only one implementation of SpeechRecognition, make that
class concrete.

BUG=223198
==========

to

==========
Devirtualize SpeechRecognitionEngine

Now that there is only one implementation of SpeechRecognitionEngine, make that
class concrete.

BUG=223198
==========

[tommi (sloooow) - chröme, 2016-04-14 14:24:29]

lgtm! Thanks for doing this the whole way through.

[hans, 2016-04-14 17:45:20]

Description was changed from

==========
Devirtualize SpeechRecognitionEngine

Now that there is only one implementation of SpeechRecognitionEngine, make that
class concrete.

BUG=223198
==========

to

==========
Devirtualize SpeechRecognitionEngine

Now that there is only one implementation of SpeechRecognitionEngine, make that
class concrete.

BUG=223198
TBR=jam
==========

[hans, 2016-04-14 17:45:42]

jam: tbr for trivial content/browser/BUILD.gn change

[hans, 2016-04-14 17:46:24]

hans@chromium.org changed reviewers:
+ jam@chromium.org

[hans, 2016-04-14 17:46:24]

> jam: tbr for trivial content/browser/BUILD.gn change

(actually adding jam to the review line this time)

[hans, 2016-04-14 17:46:29]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2016-04-14 17:46:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1891543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1891543002/20001

[commit-bot: I haz the power, 2016-04-14 18:33:56]

Description was changed from

==========
Devirtualize SpeechRecognitionEngine

Now that there is only one implementation of SpeechRecognitionEngine, make that
class concrete.

BUG=223198
TBR=jam
==========

to

==========
Devirtualize SpeechRecognitionEngine

Now that there is only one implementation of SpeechRecognitionEngine, make that
class concrete.

BUG=223198
TBR=jam
==========

[commit-bot: I haz the power, 2016-04-14 18:33:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-14 18:36:31]

Description was changed from

==========
Devirtualize SpeechRecognitionEngine

Now that there is only one implementation of SpeechRecognitionEngine, make that
class concrete.

BUG=223198
TBR=jam
==========

to

==========
Devirtualize SpeechRecognitionEngine

Now that there is only one implementation of SpeechRecognitionEngine, make that
class concrete.

BUG=223198
TBR=jam

Committed: https://crrev.com/18b756f93a5bd8a8ec402f5542905e2a7296987d
Cr-Commit-Position: refs/heads/master@{#387374}
==========

[commit-bot: I haz the power, 2016-04-14 18:36:33]

Patchset 2 (id:??) landed as
https://crrev.com/18b756f93a5bd8a8ec402f5542905e2a7296987d
Cr-Commit-Position: refs/heads/master@{#387374}