Do not use a persistent reference to store srcObject in HTMLMediaElement.

Do not use a persistent reference to store srcObject in HTMLMediaElement.

The persistent reference could lead to unexpected leaks due to reference cycles.

BUG=603493
Committed: https://crrev.com/ecc0efe17c70826d23c9aa5b9e2913eba8899838
Cr-Commit-Position: refs/heads/master@{#387581}

[Guido Urdaneta, 2016-04-14 15:41:02]

Description was changed from

==========
Do not use a persistent reference to store srcObject in HTMLMediaElement.

BUG=603493
==========

to

==========
Do not use a persistent reference to store srcObject in HTMLMediaElement.

The persistent reference could lead to unexpected leaks due to reference cycles.

BUG=603493
==========

[Guido Urdaneta, 2016-04-14 15:42:45]

guidou@chromium.org changed reviewers:
+ haraken@chromium.org, philipj@opera.com

[Guido Urdaneta, 2016-04-15 08:17:21]

In this CL the srcObject is a MediaStreamDescriptor instead of a
WebMediaPlayerSource. This eliminates the persistent reference.
When we add support for other types we'll need a MediaProvider class that
contains either a MediaStreamDescriptor or the other types. If you think it's
useful to have the MediaProvider class already, I can update this CL.

[haraken, 2016-04-15 09:11:58]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2016-04-15 09:11:58]

LGTM

[philipj_slow, 2016-04-15 09:57:16]

lgtm

[Guido Urdaneta, 2016-04-15 10:32:20]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2016-04-15 10:32:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886333002/1

[sof, 2016-04-15 10:49:14]

lgtm

https://codereview.chromium.org/1886333002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.h (right):

https://codereview.chromium.org/1886333002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.h:115:
MediaStreamDescriptor* getSrcObject() const { return m_srcObject.get(); }
nit/fyi: get() is redundant (no need to address here.)

[commit-bot: I haz the power, 2016-04-15 12:15:58]

Description was changed from

==========
Do not use a persistent reference to store srcObject in HTMLMediaElement.

The persistent reference could lead to unexpected leaks due to reference cycles.

BUG=603493
==========

to

==========
Do not use a persistent reference to store srcObject in HTMLMediaElement.

The persistent reference could lead to unexpected leaks due to reference cycles.

BUG=603493
==========

[commit-bot: I haz the power, 2016-04-15 12:15:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-15 12:18:33]

Description was changed from

==========
Do not use a persistent reference to store srcObject in HTMLMediaElement.

The persistent reference could lead to unexpected leaks due to reference cycles.

BUG=603493
==========

to

==========
Do not use a persistent reference to store srcObject in HTMLMediaElement.

The persistent reference could lead to unexpected leaks due to reference cycles.

BUG=603493

Committed: https://crrev.com/ecc0efe17c70826d23c9aa5b9e2913eba8899838
Cr-Commit-Position: refs/heads/master@{#387581}
==========

[commit-bot: I haz the power, 2016-04-15 12:18:34]

Patchset 1 (id:??) landed as
https://crrev.com/ecc0efe17c70826d23c9aa5b9e2913eba8899838
Cr-Commit-Position: refs/heads/master@{#387581}