third_party/WebKit/Source/platform/exported/WebMediaPlayerSource.cpp - Issue 1886333002: Do not use a persistent reference to store srcObject in HTMLMediaElement.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/exported/WebMediaPlayerSource.cpp

Issue 1886333002: Do not use a persistent reference to store srcObject in HTMLMediaElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/html/HTMLMediaElement.h ('K') | « third_party/WebKit/Source/modules/srcobject/HTMLMediaElementSrcObject.cpp ('k') | third_party/WebKit/public/platform/WebMediaPlayerSource.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "public/platform/WebMediaPlayerSource.h"	5 #include "public/platform/WebMediaPlayerSource.h"

6	6

7 namespace blink {	7 namespace blink {

8	8

9 WebMediaPlayerSource::WebMediaPlayerSource()	9 WebMediaPlayerSource::WebMediaPlayerSource()

10 {	10 {

(...skipping 17 matching lines...) Expand all Loading...
28 bool WebMediaPlayerSource::isURL() const	28 bool WebMediaPlayerSource::isURL() const

29 {	29 {

30 return !m_url.isEmpty();	30 return !m_url.isEmpty();

31 }	31 }

32	32

33 WebURL WebMediaPlayerSource::getAsURL() const	33 WebURL WebMediaPlayerSource::getAsURL() const

34 {	34 {

35 return m_url;	35 return m_url;

36 }	36 }

37	37

38 bool WebMediaPlayerSource::isMediaProviderObject() const

39 {

40 return isMediaStream();

41 }

42

43 bool WebMediaPlayerSource::isMediaStream() const	38 bool WebMediaPlayerSource::isMediaStream() const

44 {	39 {

45 return !m_mediaStream.isNull();	40 return !m_mediaStream.isNull();

46 }	41 }

47	42

48 WebMediaStream WebMediaPlayerSource::getAsMediaStream() const	43 WebMediaStream WebMediaPlayerSource::getAsMediaStream() const

49 {	44 {

50 return m_mediaStream;	45 return m_mediaStream;

51 }	46 }

52	47

53 } // namespace blink	48 } // namespace blink

OLD	NEW