third_party/WebKit/Source/platform/exported/WebMediaPlayerSource.cpp - Issue 1886333002: Do not use a persistent reference to store srcObject in HTMLMediaElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebMediaPlayerSource.cpp

Issue 1886333002: Do not use a persistent reference to store srcObject in HTMLMediaElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLMediaElement.h ('K') | « third_party/WebKit/Source/modules/srcobject/HTMLMediaElementSrcObject.cpp ('k') | third_party/WebKit/public/platform/WebMediaPlayerSource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebMediaPlayerSource.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebMediaPlayerSource.cpp b/third_party/WebKit/Source/platform/exported/WebMediaPlayerSource.cpp

index 7ebfd243708c79ee2848cf48d8d45caaa5aa6c05..64eaa8f1acd057bae5fff357c8d095b9e8de550a 100644

--- a/third_party/WebKit/Source/platform/exported/WebMediaPlayerSource.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebMediaPlayerSource.cpp

@@ -35,11 +35,6 @@ WebURL WebMediaPlayerSource::getAsURL() const

return m_url;

}

-bool WebMediaPlayerSource::isMediaProviderObject() const

- return isMediaStream();

bool WebMediaPlayerSource::isMediaStream() const

{

return !m_mediaStream.isNull();