Issue 1885943002: Scripts shouldn't add a non-null check in dart2js for a nullable parameter (seeWebGl.texImage2D)

Issue 1885943002: Scripts shouldn't add a non-null check in dart2js for a nullable parameter (seeWebGl.texImage2D) (Closed)

Created:
4 years, 8 months ago by Alan Knight

Modified:
4 years, 8 months ago

Reviewers:
terry

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't add a non-null check in dart2js for a nullable parameter (seeWebGl.texImage2D) BUG= Committed: https://github.com/dart-lang/sdk/commit/810faa31b9397706a73e37738e8b4a87ef23aeb1

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/web_gl/dart2js/web_gl_dart2js.dart	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (3 generated)

Alan Knight

Committed patchset #1 (id:1) manually as 810faa31b9397706a73e37738e8b4a87ef23aeb1 (presubmit successful).

4 years, 8 months ago (2016-04-16 23:26:19 UTC) #5

Message was sent while issue was closed.

lgtm