sdk/lib/html/dartium/html_dartium.dart - Issue 1885943002: Scripts shouldn't add a non-null check in dart2js for a nullable parameter (seeWebGl.texImage2D)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 1885943002: Scripts shouldn't add a non-null check in dart2js for a nullable parameter (seeWebGl.texImage2D) (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: sdk/lib/html/dartium/html_dartium.dart

diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart

index 5ff3bb57dd84f5fbbd3d46686a4abdae4992739b..369bb2844438a0231071e8ff98795836f2499c3f 100644

--- a/sdk/lib/html/dartium/html_dartium.dart

+++ b/sdk/lib/html/dartium/html_dartium.dart

@@ -37742,10 +37742,10 @@ class Url extends DartHtmlDomObject implements UrlUtils {

if ((blob_OR_source_OR_stream is Blob || blob_OR_source_OR_stream == null)) {

return _blink.BlinkURL.instance.createObjectURL_Callback_1_(blob_OR_source_OR_stream);

}

- if ((blob_OR_source_OR_stream is MediaStream)) {

+ if ((blob_OR_source_OR_stream is MediaSource)) {

return _blink.BlinkURL.instance.createObjectURL_Callback_1_(blob_OR_source_OR_stream);

}

- if ((blob_OR_source_OR_stream is MediaSource)) {

+ if ((blob_OR_source_OR_stream is MediaStream)) {

return _blink.BlinkURL.instance.createObjectURL_Callback_1_(blob_OR_source_OR_stream);

}

throw new ArgumentError("Incorrect number or type of arguments");

« no previous file with comments | « no previous file | sdk/lib/web_gl/dart2js/web_gl_dart2js.dart » ('j') | no next file with comments »