tools/dom/scripts/htmldartgenerator.py - Issue 1885943002: Scripts shouldn't add a non-null check in dart2js for a nullable parameter (seeWebGl.texImage2D)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 1885943002: Scripts shouldn't add a non-null check in dart2js for a nullable parameter (seeWebGl.texImage2D) (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/scripts/htmldartgenerator.py

diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py

index 89e3c3a7a283590744f89bd60a927482d0827755..007f3f5bd0665e9e233f8de41434e7002a419f48 100644

--- a/tools/dom/scripts/htmldartgenerator.py

+++ b/tools/dom/scripts/htmldartgenerator.py

@@ -420,7 +420,7 @@ class HtmlDartGenerator(object):

else:

checks.append('(%s is %s)' % (

parameter_name, test_type))

- elif i >= number_of_required_in_dart:

+ elif i >= number_of_required_in_dart and not argument.type.nullable:

checks.append('%s != null' % parameter_name)

# There can be multiple presence checks. We need them all since a later

« no previous file with comments | « sdk/lib/web_gl/dart2js/web_gl_dart2js.dart ('k') | no next file » | no next file with comments »