Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1885273003:
V8: Highligh slow tests not marked as slow. (Closed)
|
Created:
4 years, 8 months ago by Michael Achenbach Modified:
4 years, 8 months ago CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, Jakob Kummerow Target Ref:
refs/heads/master Project:
build Visibility:
Public. |
DescriptionV8: Highligh slow tests not marked as slow.
BUG=601468
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299951
Patch Set 1 #
Total comments: 4
Patch Set 2 : Review #Patch Set 3 : #
Messages
Total messages: 40 (20 generated)
Description was changed from ========== V8: Highligh slow tests not marked as slow. BUG= ========== to ========== V8: Highligh slow tests not marked as slow. BUG=601468 ==========
machenbach@chromium.org changed reviewers: + kjellander@chromium.org, tandrii@chromium.org
PTAL
LGTM % nit is marking with " *" sufficient though? https://codereview.chromium.org/1885273003/diff/1/scripts/slave/recipe_module... File scripts/slave/recipe_modules/v8/api.py (right): https://codereview.chromium.org/1885273003/diff/1/scripts/slave/recipe_module... scripts/slave/recipe_modules/v8/api.py:731: if 'marked_slow' in test and not test['marked_slow']: if not test.get('marked_slow'):
> > is marking with " *" sufficient though? That's the first step. I'll manually look around. After fixing a bunch I'll make this a step warning. https://codereview.chromium.org/1885273003/diff/1/scripts/slave/recipe_module... File scripts/slave/recipe_modules/v8/api.py (right): https://codereview.chromium.org/1885273003/diff/1/scripts/slave/recipe_module... scripts/slave/recipe_modules/v8/api.py:731: if 'marked_slow' in test and not test['marked_slow']: On 2016/04/14 13:00:46, tandrii(chromium) wrote: > if not test.get('marked_slow'): That has a different meaning. I don't want a * for branches, where the test driver doesn't include that field yet.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885273003/1
https://codereview.chromium.org/1885273003/diff/1/scripts/slave/recipe_module... File scripts/slave/recipe_modules/v8/api.py (right): https://codereview.chromium.org/1885273003/diff/1/scripts/slave/recipe_module... scripts/slave/recipe_modules/v8/api.py:731: if 'marked_slow' in test and not test['marked_slow']: On 2016/04/14 13:07:56, Michael Achenbach wrote: > On 2016/04/14 13:00:46, tandrii(chromium) wrote: > > if not test.get('marked_slow'): > > That has a different meaning. I don't want a * for branches, where the test > driver doesn't include that field yet. you are right. Then this is the one: if test.get('marked_slow') is False: so long as you never have {'marked_slow': None} anyway, this is nit.
The CQ bit was unchecked by machenbach@chromium.org
https://codereview.chromium.org/1885273003/diff/1/scripts/slave/recipe_module... File scripts/slave/recipe_modules/v8/api.py (right): https://codereview.chromium.org/1885273003/diff/1/scripts/slave/recipe_module... scripts/slave/recipe_modules/v8/api.py:731: if 'marked_slow' in test and not test['marked_slow']: On 2016/04/14 13:19:11, tandrii(chromium) wrote: > On 2016/04/14 13:07:56, Michael Achenbach wrote: > > On 2016/04/14 13:00:46, tandrii(chromium) wrote: > > > if not test.get('marked_slow'): > > > > That has a different meaning. I don't want a * for branches, where the test > > driver doesn't include that field yet. > > you are right. Then this is the one: > if test.get('marked_slow') is False: > > so long as you never have {'marked_slow': None} > anyway, this is nit. Done.
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org Link to the patchset: https://codereview.chromium.org/1885273003/#ps20001 (title: "Review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885273003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org Link to the patchset: https://codereview.chromium.org/1885273003/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885273003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885273003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885273003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885273003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885273003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885273003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885273003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885273003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885273003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885273003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885273003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885273003/40001
Message was sent while issue was closed.
Description was changed from ========== V8: Highligh slow tests not marked as slow. BUG=601468 ========== to ========== V8: Highligh slow tests not marked as slow. BUG=601468 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299951 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299951 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
