Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: scripts/slave/recipe_modules/v8/api.py

Issue 1885273003: V8: Highligh slow tests not marked as slow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/test_api.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import argparse 5 import argparse
6 import datetime 6 import datetime
7 import random 7 import random
8 import re 8 import re
9 import urllib 9 import urllib
10 10
(...skipping 709 matching lines...) Expand 10 before | Expand all | Expand 10 after
720 'Test: %s' % test['name'], 720 'Test: %s' % test['name'],
721 'Flags: %s' % ' '.join(test['flags']), 721 'Flags: %s' % ' '.join(test['flags']),
722 'Command: %s' % test['command'], 722 'Command: %s' % test['command'],
723 'Duration: %s' % V8Api.format_duration(test['duration']), 723 'Duration: %s' % V8Api.format_duration(test['duration']),
724 ] 724 ]
725 725
726 def _update_durations(self, output, presentation): 726 def _update_durations(self, output, presentation):
727 # Slowest tests duration summary. 727 # Slowest tests duration summary.
728 lines = [] 728 lines = []
729 for test in output['slowest_tests']: 729 for test in output['slowest_tests']:
730 suffix = ''
731 if 'marked_slow' in test and not test['marked_slow']:
tandrii(chromium) 2016/04/14 13:00:46 if not test.get('marked_slow'):
Michael Achenbach 2016/04/14 13:07:56 That has a different meaning. I don't want a * for
tandrii(chromium) 2016/04/14 13:19:11 you are right. Then this is the one: if test.get('
Michael Achenbach 2016/04/14 13:32:01 Done.
732 suffix = ' *'
730 lines.append( 733 lines.append(
731 '%s %s' %(V8Api.format_duration(test['duration']), test['name'])) 734 '%s %s%s' % (V8Api.format_duration(test['duration']),
735 test['name'], suffix))
736
732 # Slowest tests duration details. 737 # Slowest tests duration details.
733 lines.extend(['', 'Details:', '']) 738 lines.extend(['', 'Details:', ''])
734 for test in output['slowest_tests']: 739 for test in output['slowest_tests']:
735 lines.extend(self._duration_results_text(test)) 740 lines.extend(self._duration_results_text(test))
736 presentation.logs['durations'] = lines 741 presentation.logs['durations'] = lines
737 742
738 def _get_failure_logs(self, output, failure_factory): 743 def _get_failure_logs(self, output, failure_factory):
739 def all_same(items): 744 def all_same(items):
740 return all(x == items[0] for x in items) 745 return all(x == items[0] for x in items)
741 746
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
1076 def report_culprits(self, culprit_range): 1081 def report_culprits(self, culprit_range):
1077 assert culprit_range 1082 assert culprit_range
1078 if len(culprit_range) > 1: 1083 if len(culprit_range) > 1:
1079 text = 'Suspecting multiple commits' 1084 text = 'Suspecting multiple commits'
1080 else: 1085 else:
1081 text = 'Suspecting %s' % culprit_range[0][:8] 1086 text = 'Suspecting %s' % culprit_range[0][:8]
1082 1087
1083 step_result = self.m.step(text, cmd=None) 1088 step_result = self.m.step(text, cmd=None)
1084 for culprit in culprit_range: 1089 for culprit in culprit_range:
1085 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit 1090 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/test_api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698