Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: scripts/slave/recipe_modules/v8/test_api.py

Issue 1885273003: V8: Highligh slow tests not marked as slow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/v8/api.py ('k') | scripts/slave/recipes/v8.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/v8/test_api.py
diff --git a/scripts/slave/recipe_modules/v8/test_api.py b/scripts/slave/recipe_modules/v8/test_api.py
index 63d28044ffa7208f71ad76480095fd96b4ffa26d..53063095665a14e3b4141b32e4758fa4c3928116 100644
--- a/scripts/slave/recipe_modules/v8/test_api.py
+++ b/scripts/slave/recipe_modules/v8/test_api.py
@@ -40,26 +40,36 @@ class V8TestApi(recipe_test_api.RecipeTestApi):
def iter_builders(self):
return builders.iter_builders()
- def output_json(self, has_failures=False, wrong_results=False, flakes=False):
+ def output_json(self, has_failures=False, wrong_results=False, flakes=False,
+ unmarked_slow_test=False):
+ slowest_tests = V8TestApi.SLOWEST_TESTS
+ if unmarked_slow_test:
+ slowest_tests += [{
+ 'name': 'mjsunit/slow',
+ 'flags': [],
+ 'command': 'd8 -f mjsunit/slow',
+ 'duration': 123.0,
+ 'marked_slow': False,
+ }]
if not has_failures:
return self.m.json.output([{
'arch': 'theArch',
'mode': 'theMode',
'results': [],
- 'slowest_tests': V8TestApi.SLOWEST_TESTS,
+ 'slowest_tests': slowest_tests,
}])
if wrong_results:
return self.m.json.output([{
'arch': 'theArch1',
'mode': 'theMode1',
'results': [],
- 'slowest_tests': V8TestApi.SLOWEST_TESTS,
+ 'slowest_tests': slowest_tests,
},
{
'arch': 'theArch2',
'mode': 'theMode2',
'results': [],
- 'slowest_tests': V8TestApi.SLOWEST_TESTS,
+ 'slowest_tests': slowest_tests,
}])
if flakes:
return self.m.json.output([{
@@ -123,7 +133,7 @@ class V8TestApi(recipe_test_api.RecipeTestApi):
'exit_code': 1,
},
],
- 'slowest_tests': V8TestApi.SLOWEST_TESTS,
+ 'slowest_tests': slowest_tests,
}])
@@ -177,7 +187,7 @@ class V8TestApi(recipe_test_api.RecipeTestApi):
'arch': 'theArch',
'mode': 'theMode',
'results': results,
- 'slowest_tests': V8TestApi.SLOWEST_TESTS,
+ 'slowest_tests': slowest_tests,
}])
def one_failure(self):
« no previous file with comments | « scripts/slave/recipe_modules/v8/api.py ('k') | scripts/slave/recipes/v8.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698