[Merge M51] aw: Quick workaround for functor detach crash/hang

[Merge M51] aw: Quick workaround for functor detach crash/hang

Two quick fixes:
* On N where the functor detach callback is supported use it
  instead along with destroy to destroy AwGLFunctor
* In RenderThreadManager::DrawGL, make sure that
  HardwareRenderer is not re-created after window detach
  but before functor detach/destroy. Do this by checking
  if there is a frame for HardwareRenderer to consume.

Fixes above should ensure there are no crashes for using a
regular webview, but are still incomplete. These cases are
still wrong and should be fixed by the complete functor
lifetime refactor:
* Full screen video, which uses a different view (may crash)
* The pop up window flow still potentially uses the old
  functor (existing bug)
* Functor playback after window detach will not draw
  anything, which may cause flicker.

BUG=597167
Review URL: https://codereview.chromium.org/1882623002

Cr-Commit-Position: refs/heads/master@{#386831}
(cherry picked from commit ee6d581cf7f60fc79ed8b7df472fa4e58790ec22)

Committed: https://chromium.googlesource.com/chromium/src/+/cb6539bde8f3ae00e3ceed9334d8883c856d729c

[boliu, 2016-04-13 17:07:05]

Description was changed from

==========
[Merge M51] aw: Quick workaround for functor detach crash/hang

Two quick fixes:
* On N where the functor detach callback is supported use it
  instead along with destroy to destroy AwGLFunctor
* In RenderThreadManager::DrawGL, make sure that
  HardwareRenderer is not re-created after window detach
  but before functor detach/destroy. Do this by checking
  if there is a frame for HardwareRenderer to consume.

Fixes above should ensure there are no crashes for using a
regular webview, but are still incomplete. These cases are
still wrong and should be fixed by the complete functor
lifetime refactor:
* Full screen video, which uses a different view (may crash)
* The pop up window flow still potentially uses the old
  functor (existing bug)
* Functor playback after window detach will not draw
  anything, which may cause flicker.

BUG=597167

Review URL: https://codereview.chromium.org/1882623002

Cr-Commit-Position: refs/heads/master@{#386831}
(cherry picked from commit ee6d581cf7f60fc79ed8b7df472fa4e58790ec22)
==========

to

==========
[Merge M51] aw: Quick workaround for functor detach crash/hang

Two quick fixes:
* On N where the functor detach callback is supported use it
  instead along with destroy to destroy AwGLFunctor
* In RenderThreadManager::DrawGL, make sure that
  HardwareRenderer is not re-created after window detach
  but before functor detach/destroy. Do this by checking
  if there is a frame for HardwareRenderer to consume.

Fixes above should ensure there are no crashes for using a
regular webview, but are still incomplete. These cases are
still wrong and should be fixed by the complete functor
lifetime refactor:
* Full screen video, which uses a different view (may crash)
* The pop up window flow still potentially uses the old
  functor (existing bug)
* Functor playback after window detach will not draw
  anything, which may cause flicker.

BUG=597167

Review URL: https://codereview.chromium.org/1882623002

Cr-Commit-Position: refs/heads/master@{#386831}
(cherry picked from commit ee6d581cf7f60fc79ed8b7df472fa4e58790ec22)

Committed:
https://chromium.googlesource.com/chromium/src/+/cb6539bde8f3ae00e3ceed9334d8...
==========

[boliu, 2016-04-13 17:07:06]

Committed patchset #1 (id:1) manually as
cb6539bde8f3ae00e3ceed9334d8883c856d729c.