aw: Quick workaround for functor detach crash/hang

aw: Quick workaround for functor detach crash/hang

Two quick fixes:
* On N where the functor detach callback is supported use it
  instead along with destroy to destroy AwGLFunctor
* In RenderThreadManager::DrawGL, make sure that
  HardwareRenderer is not re-created after window detach
  but before functor detach/destroy. Do this by checking
  if there is a frame for HardwareRenderer to consume.

Fixes above should ensure there are no crashes for using a
regular webview, but are still incomplete. These cases are
still wrong and should be fixed by the complete functor
lifetime refactor:
* Full screen video, which uses a different view (may crash)
* The pop up window flow still potentially uses the old
  functor (existing bug)
* Functor playback after window detach will not draw
  anything, which may cause flicker.

BUG=597167
Committed: https://crrev.com/ee6d581cf7f60fc79ed8b7df472fa4e58790ec22
Cr-Commit-Position: refs/heads/master@{#386831}

[boliu, 2016-04-12 18:17:11]

boliu@chromium.org changed reviewers:
+ tobiasjs@chromium.org

[boliu, 2016-04-12 18:17:12]

see if it makes sense to you, I haven't done anything to ensure view doesn't get
gc-ed

[boliu, 2016-04-12 18:20:23]

On 2016/04/12 18:17:12, boliu wrote:
> see if it makes sense to you, I haven't done anything to ensure view doesn't
get
> gc-ed

Think I forgot the < N case..

[Tobias Sargeant, 2016-04-12 18:36:14]

https://codereview.chromium.org/1882623002/diff/1/android_webview/java/src/or...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/1882623002/diff/1/android_webview/java/src/or...
android_webview/java/src/org/chromium/android_webview/AwContents.java:1145: if
(!mFunctorDetachedCallbackPending) {
|| !mSupportsFunctorDetachedCallback

[boliu, 2016-04-12 20:24:15]

https://codereview.chromium.org/1882623002/diff/1/android_webview/java/src/or...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/1882623002/diff/1/android_webview/java/src/or...
android_webview/java/src/org/chromium/android_webview/AwContents.java:1145: if
(!mFunctorDetachedCallbackPending) {
On 2016/04/12 18:36:14, Tobias Sargeant wrote:
> || !mSupportsFunctorDetachedCallback

I'm gonna put that the condition in onDraw instead.

[boliu, 2016-04-12 20:24:20]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 20:24:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882623002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882623002/60001

[boliu, 2016-04-12 20:31:22]

Description was changed from

==========
aw: Quick workaround for functor detach crash/hang

BUG=597167
==========

to

==========
aw: Quick workaround for functor detach crash/hang

Two quick fixes:
* On N where the functor detach callback is supported use it
  instead along with destroy to destroy AwGLFunctor
* In RenderThreadManager::DrawGL, make sure that
  HardwareRenderer is not re-created after window detach
  but before functor detach/destroy. Do this by checking
  if there is a frame for HardwareRenderer to consume.

Fixes above should ensure there are no crashes for using a
regular webview, but are still incomplete. These cases are
still wrong and should be fixed by the complete functor
lifetime refactor:
* Full screen video, which uses a different view (may crash)
* The pop up window flow still potentially uses the old
  functor (existing bug)
* Functor playback after window detach will not draw
  anything, which may cause flicker.

BUG=597167
==========

[Tobias Sargeant, 2016-04-12 20:38:12]

On 2016/04/12 20:24:54, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1882623002/60001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1882623002/60001

lgtm

[commit-bot: I haz the power, 2016-04-12 21:20:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 21:20:11]

Dry run: This issue passed the CQ dry run.

[boliu, 2016-04-12 22:07:14]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2016-04-12 22:07:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882623002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882623002/60001

[commit-bot: I haz the power, 2016-04-12 22:13:28]

Description was changed from

==========
aw: Quick workaround for functor detach crash/hang

Two quick fixes:
* On N where the functor detach callback is supported use it
  instead along with destroy to destroy AwGLFunctor
* In RenderThreadManager::DrawGL, make sure that
  HardwareRenderer is not re-created after window detach
  but before functor detach/destroy. Do this by checking
  if there is a frame for HardwareRenderer to consume.

Fixes above should ensure there are no crashes for using a
regular webview, but are still incomplete. These cases are
still wrong and should be fixed by the complete functor
lifetime refactor:
* Full screen video, which uses a different view (may crash)
* The pop up window flow still potentially uses the old
  functor (existing bug)
* Functor playback after window detach will not draw
  anything, which may cause flicker.

BUG=597167
==========

to

==========
aw: Quick workaround for functor detach crash/hang

Two quick fixes:
* On N where the functor detach callback is supported use it
  instead along with destroy to destroy AwGLFunctor
* In RenderThreadManager::DrawGL, make sure that
  HardwareRenderer is not re-created after window detach
  but before functor detach/destroy. Do this by checking
  if there is a frame for HardwareRenderer to consume.

Fixes above should ensure there are no crashes for using a
regular webview, but are still incomplete. These cases are
still wrong and should be fixed by the complete functor
lifetime refactor:
* Full screen video, which uses a different view (may crash)
* The pop up window flow still potentially uses the old
  functor (existing bug)
* Functor playback after window detach will not draw
  anything, which may cause flicker.

BUG=597167
==========

[commit-bot: I haz the power, 2016-04-12 22:13:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-12 22:15:39]

Description was changed from

==========
aw: Quick workaround for functor detach crash/hang

Two quick fixes:
* On N where the functor detach callback is supported use it
  instead along with destroy to destroy AwGLFunctor
* In RenderThreadManager::DrawGL, make sure that
  HardwareRenderer is not re-created after window detach
  but before functor detach/destroy. Do this by checking
  if there is a frame for HardwareRenderer to consume.

Fixes above should ensure there are no crashes for using a
regular webview, but are still incomplete. These cases are
still wrong and should be fixed by the complete functor
lifetime refactor:
* Full screen video, which uses a different view (may crash)
* The pop up window flow still potentially uses the old
  functor (existing bug)
* Functor playback after window detach will not draw
  anything, which may cause flicker.

BUG=597167
==========

to

==========
aw: Quick workaround for functor detach crash/hang

Two quick fixes:
* On N where the functor detach callback is supported use it
  instead along with destroy to destroy AwGLFunctor
* In RenderThreadManager::DrawGL, make sure that
  HardwareRenderer is not re-created after window detach
  but before functor detach/destroy. Do this by checking
  if there is a frame for HardwareRenderer to consume.

Fixes above should ensure there are no crashes for using a
regular webview, but are still incomplete. These cases are
still wrong and should be fixed by the complete functor
lifetime refactor:
* Full screen video, which uses a different view (may crash)
* The pop up window flow still potentially uses the old
  functor (existing bug)
* Functor playback after window detach will not draw
  anything, which may cause flicker.

BUG=597167

Committed: https://crrev.com/ee6d581cf7f60fc79ed8b7df472fa4e58790ec22
Cr-Commit-Position: refs/heads/master@{#386831}
==========

[commit-bot: I haz the power, 2016-04-12 22:15:40]

Patchset 4 (id:??) landed as
https://crrev.com/ee6d581cf7f60fc79ed8b7df472fa4e58790ec22
Cr-Commit-Position: refs/heads/master@{#386831}