Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: android_webview/browser/render_thread_manager.cc

Issue 1885103002: [Merge M51] aw: Quick workaround for functor detach crash/hang (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/render_thread_manager.cc
diff --git a/android_webview/browser/render_thread_manager.cc b/android_webview/browser/render_thread_manager.cc
index 8338278941b7063885fd72beabf60ba3e2534358..df7331a19a64058a3e1f9e0db7831fdbcff52cf8 100644
--- a/android_webview/browser/render_thread_manager.cc
+++ b/android_webview/browser/render_thread_manager.cc
@@ -280,11 +280,12 @@ void RenderThreadManager::DrawGL(AwDrawGLInfo* draw_info) {
// Set the correct FBO before kModeDraw. The GL commands run in kModeDraw
// require a correctly bound FBO. The FBO remains until the next kModeDraw.
// So kModeProcess between kModeDraws has correctly bound FBO, too.
- if (draw_info->mode == AwDrawGLInfo::kModeDraw) {
- if (!hardware_renderer_) {
- hardware_renderer_.reset(new HardwareRenderer(this));
- hardware_renderer_->CommitFrame();
- }
+ if (draw_info->mode == AwDrawGLInfo::kModeDraw && !hardware_renderer_ &&
+ HasFrameForHardwareRendererOnRT()) {
+ hardware_renderer_.reset(new HardwareRenderer(this));
+ hardware_renderer_->CommitFrame();
+ }
+ if (hardware_renderer_) {
hardware_renderer_->SetBackingFrameBufferObject(
state_restore.framebuffer_binding_ext());
}
@@ -310,7 +311,8 @@ void RenderThreadManager::DrawGL(AwDrawGLInfo* draw_info) {
return;
}
- hardware_renderer_->DrawGL(draw_info, state_restore);
+ if (hardware_renderer_)
+ hardware_renderer_->DrawGL(draw_info, state_restore);
DeferredGpuCommandService::GetInstance()->PerformIdleWork(false);
}
@@ -356,6 +358,11 @@ bool RenderThreadManager::HasFrameOnUI() const {
return hardware_renderer_has_frame_ || child_frame_.get();
}
+bool RenderThreadManager::HasFrameForHardwareRendererOnRT() const {
+ base::AutoLock lock(lock_);
+ return !!child_frame_;
+}
+
void RenderThreadManager::InitializeHardwareDrawIfNeededOnUI() {
DCHECK(ui_loop_->BelongsToCurrentThread());
GLViewRendererManager* manager = GLViewRendererManager::GetInstance();
« no previous file with comments | « android_webview/browser/render_thread_manager.h ('k') | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698