Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: build/config/win/BUILD.gn

Issue 1884973002: clang/win: Disable incremental linking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/compiler/compiler.gni") 5 import("//build/config/compiler/compiler.gni")
6 import("//build/config/sanitizers/sanitizers.gni") 6 import("//build/config/sanitizers/sanitizers.gni")
7 import("//build/config/win/visual_studio_version.gni") 7 import("//build/config/win/visual_studio_version.gni")
8 8
9 assert(is_win) 9 assert(is_win)
10 10
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 ldflags = [ "/SUBSYSTEM:CONSOLE$subsystem_version_suffix" ] 292 ldflags = [ "/SUBSYSTEM:CONSOLE$subsystem_version_suffix" ]
293 } 293 }
294 config("windowed") { 294 config("windowed") {
295 ldflags = [ "/SUBSYSTEM:WINDOWS$subsystem_version_suffix" ] 295 ldflags = [ "/SUBSYSTEM:WINDOWS$subsystem_version_suffix" ]
296 } 296 }
297 297
298 # Incremental linking ---------------------------------------------------------- 298 # Incremental linking ----------------------------------------------------------
299 299
300 incremental_linking_on_switch = [ "/INCREMENTAL" ] 300 incremental_linking_on_switch = [ "/INCREMENTAL" ]
301 incremental_linking_off_switch = [ "/INCREMENTAL:NO" ] 301 incremental_linking_off_switch = [ "/INCREMENTAL:NO" ]
302 if (is_debug) { 302
303 # MSVC2015's incremental linker complains about clang's .obj files sometimes,
304 # https://crbug.com/595702. Disable incremental linking with clang for now.
305 # TODO(thakis): Remove this once that problem is fixed, or when the win_clang
306 # bot uses lld.
307 if (is_debug && !is_clang) {
303 default_incremental_linking_switch = incremental_linking_on_switch 308 default_incremental_linking_switch = incremental_linking_on_switch
304 } else { 309 } else {
305 default_incremental_linking_switch = incremental_linking_off_switch 310 default_incremental_linking_switch = incremental_linking_off_switch
306 } 311 }
307 312
308 # Applies incremental linking or not depending on the current configuration. 313 # Applies incremental linking or not depending on the current configuration.
309 config("default_incremental_linking") { 314 config("default_incremental_linking") {
310 ldflags = default_incremental_linking_switch 315 ldflags = default_incremental_linking_switch
311 } 316 }
312 317
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 383
379 # Internal stuff -------------------------------------------------------------- 384 # Internal stuff --------------------------------------------------------------
380 385
381 # Config used by the MIDL template to disable warnings. 386 # Config used by the MIDL template to disable warnings.
382 config("midl_warnings") { 387 config("midl_warnings") {
383 if (is_clang) { 388 if (is_clang) {
384 # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_". 389 # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_".
385 cflags = [ "-Wno-extra-tokens" ] 390 cflags = [ "-Wno-extra-tokens" ]
386 } 391 }
387 } 392 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698