Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4083)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/win/BUILD.gn

Issue 1884973002: clang/win: Disable incremental linking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/win/BUILD.gn
diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn
index db3cdca704f6143a9d47d2481342cc7e4f6fdd8b..f48b4640dc4093c308c8e0335b137bc081609136 100644
--- a/build/config/win/BUILD.gn
+++ b/build/config/win/BUILD.gn
@@ -299,7 +299,12 @@ config("windowed") {
incremental_linking_on_switch = [ "/INCREMENTAL" ]
incremental_linking_off_switch = [ "/INCREMENTAL:NO" ]
-if (is_debug) {
+
+# MSVC2015's incremental linker complains about clang's .obj files sometimes,
+# https://crbug.com/595702. Disable incremental linking with clang for now.
+# TODO(thakis): Remove this once that problem is fixed, or when the win_clang
+# bot uses lld.
+if (is_debug && !is_clang) {
default_incremental_linking_switch = incremental_linking_on_switch
} else {
default_incremental_linking_switch = incremental_linking_off_switch
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698