Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1884963002: Make build_shaderc.py blow away output dir and allow build_type arg to contain either Debug or Relea (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
borenet, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make build_shaderc.py blow away output dir and allow build_type arg to contain either Debug or Release GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1884963002 Committed: https://skia.googlesource.com/skia/+/09e127bd38d4f972134afca77184b217a9708b3a

Patch Set 1 #

Patch Set 2 : new approach #

Patch Set 3 : shaderc_build_configuration init #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M gyp/shaderc.gyp View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M tools/build_shaderc.py View 1 2 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
bsalomon
I couldn't figure out how to make the logic in shaderc.gyp handle CONFIGURATION_NAME variations. Using ...
4 years, 8 months ago (2016-04-13 14:34:08 UTC) #4
borenet
LGTM
4 years, 8 months ago (2016-04-13 14:45:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884963002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884963002/40001
4 years, 8 months ago (2016-04-13 14:53:17 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 15:02:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/09e127bd38d4f972134afca77184b217a9708b3a

Powered by Google App Engine
This is Rietveld 408576698