Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: gyp/shaderc.gyp

Issue 1884963002: Make build_shaderc.py blow away output dir and allow build_type arg to contain either Debug or Relea (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: shaderc_build_configuration init Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/build_shaderc.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/shaderc.gyp
diff --git a/gyp/shaderc.gyp b/gyp/shaderc.gyp
index 26af80a4d1e19f5f0613dc214bd7c21c368f19ad..7732e221ac049547005717b29367c9b6fa563df1 100644
--- a/gyp/shaderc.gyp
+++ b/gyp/shaderc.gyp
@@ -8,12 +8,8 @@
'variables': {
'variables': { # This is the dreaded nested variables dict so that we can
# have dependent variables
+ 'shaderc_build_configuration': '<(CONFIGURATION_NAME)',
'conditions': [
- [ 'CONFIGURATION_NAME == "Release_Developer"', {
- 'shaderc_build_configuration' : 'Release',
- }, {
- 'shaderc_build_configuration' : '<(CONFIGURATION_NAME)',
- }],
[ 'skia_os == "win"', {
'shaderc_lib_name' : 'shaderc_combined.lib',
}, {
« no previous file with comments | « no previous file | tools/build_shaderc.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698