Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1884873006: Rename lots of things from 'sRGB' to 'GammaCorrect', where appropriate (Closed)

Created:
4 years, 8 months ago by Brian Osman
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename lots of things from 'sRGB' to 'GammaCorrect', where appropriate Trying to be much more explicit about where we really mean sRGB as a format, and where we mean gamma-correct, as in: "not legacy behavior". Most of the changes to rendering behavior are dependent on the latter, so let's be precise. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1884873006 Committed: https://skia.googlesource.com/skia/+/b461d3457567cf79a3efac3123c00f7afc37fecb

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -89 lines) Patch
M dm/DMGpuSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M gm/dftext.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/surface.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M gm/textblobgeometrychange.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/textblobmixedsizes.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/textblobrandomfont.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M include/core/SkSurfaceProps.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/GrDrawContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrPaint.h View 1 chunk +9 lines, -0 lines 2 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkGpuBlurUtils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 17 chunks +20 lines, -20 lines 0 comments Download
M src/gpu/SkGpuDevice_drawTexture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.cpp View 3 chunks +8 lines, -5 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.h View 2 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 4 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/text/GrDistanceFieldAdjustTable.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/text/GrDistanceFieldAdjustTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/views/SkWindow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Brian Osman
Before I start changing plumbing, I wanted to do a quick (separate) renaming pass. This ...
4 years, 8 months ago (2016-04-13 19:54:52 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884873006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884873006/1
4 years, 8 months ago (2016-04-13 19:55:02 UTC) #5
bsalomon
lgtm https://codereview.chromium.org/1884873006/diff/1/include/gpu/GrPaint.h File include/gpu/GrPaint.h (right): https://codereview.chromium.org/1884873006/diff/1/include/gpu/GrPaint.h#newcode77 include/gpu/GrPaint.h:77: void setGammaCorrect(bool gammaCorrect) { On 2016/04/13 19:54:52, Brian ...
4 years, 8 months ago (2016-04-13 20:03:38 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 20:04:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884873006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884873006/1
4 years, 8 months ago (2016-04-13 20:09:17 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 20:10:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b461d3457567cf79a3efac3123c00f7afc37fecb

Powered by Google App Engine
This is Rietveld 408576698