Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2165)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 1884863003: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename Have->Has add browsertest Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index 19aa49773b2f61f4167bfa6b31d4d144a9b536d2..4de07f7d3b8db968a8e07c7e24122715b82f0a57 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -1497,6 +1497,9 @@ class LayerTreeHostTestCommit : public LayerTreeHostTest {
EventListenerClass::kMouseWheel, EventListenerProperties::kPassive);
layer_tree_host()->SetEventListenerProperties(
EventListenerClass::kTouch, EventListenerProperties::kBlocking);
+ layer_tree_host()->SetEventListenerProperties(
+ EventListenerClass::kTouchEndOrCancel,
+ EventListenerProperties::kBlockingAndPassive);
layer_tree_host()->SetHaveScrollEventHandlers(true);
PostSetNeedsCommitToMainThread();
@@ -1511,6 +1514,9 @@ class LayerTreeHostTestCommit : public LayerTreeHostTest {
EXPECT_EQ(EventListenerProperties::kBlocking,
impl->active_tree()->event_listener_properties(
EventListenerClass::kTouch));
+ EXPECT_EQ(EventListenerProperties::kBlockingAndPassive,
+ impl->active_tree()->event_listener_properties(
+ EventListenerClass::kTouchEndOrCancel));
EXPECT_TRUE(impl->active_tree()->have_scroll_event_handlers());
EndTest();

Powered by Google App Engine
This is Rietveld 408576698