cc/trees/layer_tree_host.cc - Issue 1884863003: Non passive touch end or touch cancel listeners should not block scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host.cc

Issue 1884863003: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename Have->Has add browsertest Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/proto/layer_tree_host.proto ('k') | cc/trees/layer_tree_host_unittest.cc » ('j') | third_party/WebKit/LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/trees/layer_tree_host.cc

diff --git a/cc/trees/layer_tree_host.cc b/cc/trees/layer_tree_host.cc

index 365008b8cbe727feeb35c6e6c9f0014554a08328..d7916ee690add6a2b8848f402e64963f8e9ddfe1 100644

--- a/cc/trees/layer_tree_host.cc

+++ b/cc/trees/layer_tree_host.cc

@@ -446,6 +446,9 @@ void LayerTreeHost::FinishCommitOnImplThread(LayerTreeHostImpl* host_impl) {

sync_tree->set_event_listener_properties(

EventListenerClass::kMouseWheel,

event_listener_properties(EventListenerClass::kMouseWheel));

+ sync_tree->set_event_listener_properties(

+ EventListenerClass::kTouchEndOrCancel,

+ event_listener_properties(EventListenerClass::kTouchEndOrCancel));

if (page_scale_layer_.get() && inner_viewport_scroll_layer_.get()) {

sync_tree->SetViewportLayersFromIds(

@@ -1531,6 +1534,9 @@ void LayerTreeHost::ToProtobufForCommit(proto::LayerTreeHost* proto) {

event_listener_properties(EventListenerClass::kMouseWheel)));

proto->set_touch_event_listener_properties(static_cast<uint32_t>(

event_listener_properties(EventListenerClass::kTouch)));

+ proto->set_touch_end_or_cancel_event_listener_properties(

+ static_cast<uint32_t>(

+ event_listener_properties(EventListenerClass::kTouchEndOrCancel)));

proto->set_in_paint_layer_contents(in_paint_layer_contents_);

proto->set_id(id_);

proto->set_next_commit_forces_redraw(next_commit_forces_redraw_);

@@ -1602,6 +1608,10 @@ void LayerTreeHost::FromProtobufForCommit(const proto::LayerTreeHost& proto) {

event_listener_properties_[static_cast<size_t>(EventListenerClass::kTouch)] =

static_cast<EventListenerProperties>(

proto.touch_event_listener_properties());

+ event_listener_properties_[static_cast<size_t>(

+ EventListenerClass::kTouchEndOrCancel)] =

+ static_cast<EventListenerProperties>(

+ proto.touch_end_or_cancel_event_listener_properties());

in_paint_layer_contents_ = proto.in_paint_layer_contents();

id_ = proto.id();

next_commit_forces_redraw_ = proto.next_commit_forces_redraw();