third_party/WebKit/LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects.js - Issue 1884863003: Non passive touch end or touch cancel listeners should not block scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects.js

Issue 1884863003: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename Have->Has add browsertest Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/non_blocking_event_browsertest.cc ('k') | third_party/WebKit/LayoutTests/fast/events/touch/touch-handler-count.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects.js

diff --git a/third_party/WebKit/LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects.js b/third_party/WebKit/LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects.js

index a6c6e27d9f25ae4fc0f9b4dc9c5b922aec46a469..d7513b43b14b4c169aff46eaf3292975a928b228 100644

--- a/third_party/WebKit/LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects.js

+++ b/third_party/WebKit/LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects.js

@@ -136,6 +136,12 @@ if (window.internals) {

window.onload = function() {

// Run each general test case.

var tests = document.querySelectorAll('.testcase');

+ // Add document wide touchend and touchcancel listeners to ensure the

+ // listeners do not effect compositor hit test rects.

tdresser 2016/04/13 18:44:40 Nittiest nit: effect -> affect

dtapuska 2016/04/13 18:49:08 Done.

+ document.documentElement.addEventListener('touchend', listener, false);

+ document.documentElement.addEventListener('touchcancel', listener, false);

for ( var i = 0; i < tests.length; i++) {

// Force a compositing update before testing each case to ensure that

// any subsequent touch rect updates are actually done because of