Android: Avoid linking with --gc-sections.

Android: Avoid linking with --gc-sections.

No more --gc-sections in debug mode for non-test targets.

BUG=159847
Committed: https://crrev.com/7987e9767be6e2a3459db0779dfb8664056eccf1
Cr-Commit-Position: refs/heads/master@{#387112}

[Lei Zhang, 2016-04-13 10:21:47]

thestig@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Lei Zhang, 2016-04-13 10:21:47]

Others must have pitched in without taking any credit, because there was more to
do when I checked 6 months ago.

[Yaron, 2016-04-13 14:39:55]

On 2016/04/13 10:21:47, Lei Zhang wrote:
> Others must have pitched in without taking any credit, because there was more
to
> do when I checked 6 months ago.

Looks like it may still be on for release build s(if I'm reading
build/config/compiler/BUILD.gn correctly)
Still, I'm surprised too.
Can you update comments in build/config/sanitizers/BUILD.gn ?
Also it looks like unit_tests may still depend on this flag

[Lei Zhang, 2016-04-13 20:32:25]

On 2016/04/13 14:39:55, Yaron wrote:
> On 2016/04/13 10:21:47, Lei Zhang wrote:
> > Others must have pitched in without taking any credit, because there was
more
> to
> > do when I checked 6 months ago.
> 
> Looks like it may still be on for release build s(if I'm reading
> build/config/compiler/BUILD.gn correctly)

Yes, just like on other platforms.

> Can you update comments in build/config/sanitizers/BUILD.gn ?

Let me see if the ASAN build works with instrumentation of globals enabled.
FWIW, this is https://crbug.com/159801 and the same block is in
build/common.gypi as well. Will get back to you in a bit.

> Also it looks like unit_tests may still depend on this flag

Yes, that will be the next round.

[Lei Zhang, 2016-04-13 20:47:22]

On 2016/04/13 20:32:25, Lei Zhang wrote:
> > Can you update comments in build/config/sanitizers/BUILD.gn ?
> 
> Let me see if the ASAN build works with instrumentation of globals enabled.
> FWIW, this is https://crbug.com/159801 and the same block is in
> build/common.gypi as well. Will get back to you in a bit.

unit_tests_apk does not link if I enable instrumentation of globals.

> > Also it looks like unit_tests may still depend on this flag
> 
> Yes, that will be the next round.

Maybe in this round, I can deal with build/config/sanitizers/BUILD.gn.

So this is as good as it gets for this CL.

[Yaron, 2016-04-13 20:56:43]

On 2016/04/13 20:47:22, Lei Zhang wrote:
> On 2016/04/13 20:32:25, Lei Zhang wrote:
> > > Can you update comments in build/config/sanitizers/BUILD.gn ?
> > 
> > Let me see if the ASAN build works with instrumentation of globals enabled.
> > FWIW, this is https://crbug.com/159801 and the same block is in
> > build/common.gypi as well. Will get back to you in a bit.
> 
> unit_tests_apk does not link if I enable instrumentation of globals.
> 
> > > Also it looks like unit_tests may still depend on this flag
> > 
> > Yes, that will be the next round.
> 
> Maybe in this round, I can deal with build/config/sanitizers/BUILD.gn.
> 
> So this is as good as it gets for this CL.

So the main thing I was hoping for was to update the comment in
sanitizers/BUILD.gn that things in android still rely on gc-sections since it
wasn't true anymore. That said, it is still true cause of unit_tests which I
agree is reasonable for a follow-up so lgtm

[Lei Zhang, 2016-04-13 21:02:51]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-04-13 21:03:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884543004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884543004/1

[commit-bot: I haz the power, 2016-04-13 21:52:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-13 21:53:51]

Description was changed from

==========
Android: Avoid linking with --gc-sections.

No more --gc-sections in debug mode for non-test targets.

BUG=159847
==========

to

==========
Android: Avoid linking with --gc-sections.

No more --gc-sections in debug mode for non-test targets.

BUG=159847

Committed: https://crrev.com/7987e9767be6e2a3459db0779dfb8664056eccf1
Cr-Commit-Position: refs/heads/master@{#387112}
==========

[commit-bot: I haz the power, 2016-04-13 21:53:52]

Patchset 1 (id:??) landed as
https://crrev.com/7987e9767be6e2a3459db0779dfb8664056eccf1
Cr-Commit-Position: refs/heads/master@{#387112}