Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: chrome/android/chrome_apk.gyp

Issue 1884543004: Android: Avoid linking with --gc-sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/browser/lifetime/application_lifetime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'includes': [ 5 'includes': [
6 '../../chrome/chrome_android_paks.gypi', # Included for the list of pak reso urces. 6 '../../chrome/chrome_android_paks.gypi', # Included for the list of pak reso urces.
7 '../../build/util/version.gypi' 7 '../../build/util/version.gypi'
8 ], 8 ],
9 'variables': { 9 'variables': {
10 'chromium_code': 1, 10 'chromium_code': 1,
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 { 96 {
97 # The base library used in both ChromePublic and ChromeSyncShell. 97 # The base library used in both ChromePublic and ChromeSyncShell.
98 'target_name': 'libchrome_public_base', 98 'target_name': 'libchrome_public_base',
99 'type': 'none', 99 'type': 'none',
100 'dependencies': [ 100 'dependencies': [
101 '../../chrome/chrome.gyp:chrome_android_core', 101 '../../chrome/chrome.gyp:chrome_android_core',
102 ], 102 ],
103 'include_dirs': [ 103 'include_dirs': [
104 '../..', 104 '../..',
105 ], 105 ],
106 'direct_dependent_settings': {
107 'ldflags': [
108 # Some android targets still depend on --gc-sections to link.
109 # TODO: remove --gc-sections for Debug builds (crbug.com/159847).
110 '-Wl,--gc-sections',
111 ],
112 },
113 'conditions': [ 106 'conditions': [
114 # TODO(yfriedman): move this DEP to chrome_android_core to be shared 107 # TODO(yfriedman): move this DEP to chrome_android_core to be shared
115 # between internal/external. 108 # between internal/external.
116 ['cld_version==2', { 109 ['cld_version==2', {
117 'dependencies': [ 110 'dependencies': [
118 '../../third_party/cld_2/cld_2.gyp:cld2_dynamic', 111 '../../third_party/cld_2/cld_2.gyp:cld2_dynamic',
119 ], 112 ],
120 }], 113 }],
121 # conditions for order_text_section 114 # conditions for order_text_section
122 # Cygprofile methods need to be linked into the instrumented build. 115 # Cygprofile methods need to be linked into the instrumented build.
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
420 } 413 }
421 ], 414 ],
422 ], 415 ],
423 } 416 }
424 417
425 # Local Variables: 418 # Local Variables:
426 # tab-width:2 419 # tab-width:2
427 # indent-tabs-mode:nil 420 # indent-tabs-mode:nil
428 # End: 421 # End:
429 # vim: set expandtab tabstop=2 shiftwidth=2: 422 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/browser/lifetime/application_lifetime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698