Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/BUILD.gn

Issue 1884543004: Android: Avoid linking with --gc-sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/chrome_apk.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index fd49b1358fb89328b88de0d2011dc8cae83acdd4..c6288239834261602d00f0f2104a5626ff6e7bc5 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -987,12 +987,6 @@ if (is_android) {
]
}
- # Some android targets still depend on --gc-sections to link.
- # TODO: remove --gc-sections for Debug builds (crbug.com/159847).
- config("gc_sections") {
- ldflags = [ "-Wl,--gc-sections" ]
- }
-
# GYP: //chrome/chrome_android.gypi:chrome_android_core
source_set("chrome_android_core") {
sources = [
@@ -1005,7 +999,6 @@ if (is_android) {
"app/chrome_main_delegate.cc",
"app/chrome_main_delegate.h",
]
- public_configs = [ ":gc_sections" ]
include_dirs = [ android_ndk_include_dir ]
« no previous file with comments | « no previous file | chrome/android/chrome_apk.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698