Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1884213003: DevTools: teach SourceMapNamesResolver to resolve "this" object (Closed)

Created:
4 years, 8 months ago by lushnikov
Modified:
4 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ids
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: teach SourceMapNamesResolver to resolve "this" object BUG=none R=dgozman, pfeldman_ooo Committed: https://crrev.com/f4d49ed057dbc5f23a3349b26e7f6842c4fe8614 Cr-Commit-Position: refs/heads/master@{#387717}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix tesst #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -32 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-expand-scope.html View 1 1 chunk +11 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes.html View 1 1 chunk +11 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-proto-property.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-minified-variables.html View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-identifiers.html View 1 chunk +6 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this.html View 2 chunks +7 lines, -9 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this-expected.txt View 1 chunk +4 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/resolve-this.js View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/resolve-this.ts View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/resolve-this.js.map View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/platform/utilities.js View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js View 3 chunks +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js View 1 chunk +42 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1887913002 Patch 40001

Messages

Total messages: 13 (5 generated)
lushnikov
please, take a look!
4 years, 8 months ago (2016-04-15 01:28:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884213003/1
4 years, 8 months ago (2016-04-15 03:16:23 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/212969)
4 years, 8 months ago (2016-04-15 04:38:47 UTC) #5
dgozman
lgtm https://codereview.chromium.org/1884213003/diff/1/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js File third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js (right): https://codereview.chromium.org/1884213003/diff/1/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js#newcode45 third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js:45: WebInspector.SourceMapNamesResolver.resolveThisObject(callFrame) I think this extra async will break ...
4 years, 8 months ago (2016-04-15 17:37:31 UTC) #6
lushnikov
https://codereview.chromium.org/1884213003/diff/1/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js File third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js (right): https://codereview.chromium.org/1884213003/diff/1/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js#newcode45 third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js:45: WebInspector.SourceMapNamesResolver.resolveThisObject(callFrame) On 2016/04/15 17:37:31, dgozman wrote: > I think ...
4 years, 8 months ago (2016-04-15 20:59:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884213003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884213003/20001
4 years, 8 months ago (2016-04-15 20:59:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 22:12:09 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 22:14:48 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f4d49ed057dbc5f23a3349b26e7f6842c4fe8614
Cr-Commit-Position: refs/heads/master@{#387717}

Powered by Google App Engine
This is Rietveld 408576698