DevTools: improve identifier extraction in SourceMapNamesResolver

DevTools: improve identifier extraction in SourceMapNamesResolver

Apart from extracting identifier names from SourceMap.name entries,
this patch attempts to extract variable names from a mapped source.

BUG=none
R=dgozman, pfeldman_ooo

Committed: https://crrev.com/62ae3bbfa1d26c5e2b175b9e894bbf9d78a859de
Cr-Commit-Position: refs/heads/master@{#387533}

[lushnikov, 2016-04-14 02:02:11]

ptal!

[lushnikov, 2016-04-14 02:03:17]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 02:03:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887913002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887913002/1

[commit-bot: I haz the power, 2016-04-14 04:19:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 04:19:02]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-04-14 19:15:38]

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/common/Text.js (right):

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/common/Text.js:134: setOffset:
function(offset)
resetTo

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js
(right):

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:137:
var functionDeclarationCounter = 0;
Remove this one.

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:146:
return node.type === "FunctionDeclaration" || node.type ===
"FunctionExpression";
+ArrowFunctionExpression

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:152:
function beforeVisit(node)
Let's add tests.

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:157:
if (node.type === "VariableDeclarator")
Remove this one.

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:160:
if (node.object.type === "Identifier")
Ignore "property" identifier of "MemberExpression"[computed=false] instead.

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:174:
identifiers.pushAll(functionNode.params);
for (var param of functionNode.params)
    walker.walk(param)

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
(right):

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js:36:
var promise = script.requestContent().then(onContent);
return it

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js:161:
var text = textCache.get(uiSourceCode);
Make it per-content instead of per-uisourcecode.

[lushnikov, 2016-04-15 00:16:02]

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/common/Text.js (right):

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/common/Text.js:134: setOffset:
function(offset)
On 2016/04/14 19:15:37, dgozman wrote:
> resetTo

Done.

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js
(right):

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:137:
var functionDeclarationCounter = 0;
On 2016/04/14 19:15:37, dgozman wrote:
> Remove this one.

Done.

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:146:
return node.type === "FunctionDeclaration" || node.type ===
"FunctionExpression";
On 2016/04/14 19:15:37, dgozman wrote:
> +ArrowFunctionExpression

Done.

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:152:
function beforeVisit(node)
On 2016/04/14 19:15:37, dgozman wrote:
> Let's add tests.

Done.

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:157:
if (node.type === "VariableDeclarator")
On 2016/04/14 19:15:37, dgozman wrote:
> Remove this one.

Done.

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:160:
if (node.object.type === "Identifier")
On 2016/04/14 19:15:37, dgozman wrote:
> Ignore "property" identifier of "MemberExpression"[computed=false] instead.

Done.

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js:174:
identifiers.pushAll(functionNode.params);
On 2016/04/14 19:15:37, dgozman wrote:
> for (var param of functionNode.params)
>     walker.walk(param)

Done.

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
(right):

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js:36:
var promise = script.requestContent().then(onContent);
On 2016/04/14 19:15:37, dgozman wrote:
> return it

Done.

https://codereview.chromium.org/1887913002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js:161:
var text = textCache.get(uiSourceCode);
On 2016/04/14 19:15:37, dgozman wrote:
> Make it per-content instead of per-uisourcecode.

Done.

[dgozman, 2016-04-15 00:40:44]

lgtm

https://codereview.chromium.org/1887913002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
(right):

https://codereview.chromium.org/1887913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js:186:
function onSourceText(sourceTextRange, text)
Merge this into previous one.

[lushnikov, 2016-04-15 00:45:48]

https://codereview.chromium.org/1887913002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
(right):

https://codereview.chromium.org/1887913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js:186:
function onSourceText(sourceTextRange, text)
On 2016/04/15 00:40:43, dgozman wrote:
> Merge this into previous one.

Done.

[lushnikov, 2016-04-15 00:45:56]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-04-15 00:45:56]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1887913002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-04-15 00:46:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887913002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887913002/40001

[commit-bot: I haz the power, 2016-04-15 03:15:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-15 03:16:46]

Description was changed from

==========
DevTools: improve identifier extraction in SourceMapNamesResolver

Apart from extracting identifier names from SourceMap.name entries,
this patch attempts to extract variable names from a mapped source.

BUG=none
R=dgozman, pfeldman_ooo
==========

to

==========
DevTools: improve identifier extraction in SourceMapNamesResolver

Apart from extracting identifier names from SourceMap.name entries,
this patch attempts to extract variable names from a mapped source.

BUG=none
R=dgozman, pfeldman_ooo

Committed: https://crrev.com/62ae3bbfa1d26c5e2b175b9e894bbf9d78a859de
Cr-Commit-Position: refs/heads/master@{#387533}
==========

[commit-bot: I haz the power, 2016-04-15 03:16:48]

Patchset 3 (id:??) landed as
https://crrev.com/62ae3bbfa1d26c5e2b175b9e894bbf9d78a859de
Cr-Commit-Position: refs/heads/master@{#387533}