Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this.html

Issue 1884213003: DevTools: teach SourceMapNamesResolver to resolve "this" object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ids
Patch Set: fix tesst Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this.html
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-minified-variables.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this.html
similarity index 55%
copy from third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-minified-variables.html
copy to third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this.html
index f68dd9755a5bb13a49b85d725a23b3f225449ff9..400889effa780765bc741652bf74736e97ed7cf6 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-minified-variables.html
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this.html
@@ -2,23 +2,21 @@
<head>
<script src="../../../http/tests/inspector/inspector-test.js"></script>
<script src="../../../http/tests/inspector/debugger-test.js"></script>
-<script src="resources/resolve-variable-names-compressed.js"></script>
+<script src="resources/resolve-this.js"></script>
<script>
function test()
{
Runtime.experiments.enableForTest("resolveVariableNames");
- InspectorTest.startDebuggerTest(() => InspectorTest.runTestFunctionAndWaitUntilPaused());
- var resolvedScopes = 0;
- InspectorTest.addSniffer(WebInspector.SourceMapNamesResolver, "_scopeResolvedForTest", onScopeResolved, true);
+ InspectorTest.waitForScriptSource("resolve-this.ts", onSourceMapLoaded);
- function onScopeResolved()
+ function onSourceMapLoaded()
{
- if (++resolvedScopes === 2)
- onAllScopesResolved();
+ InspectorTest.startDebuggerTest(() => InspectorTest.runTestFunctionAndWaitUntilPaused());
+ InspectorTest.addSniffer(WebInspector.ScopeChainSidebarPane.prototype, "_sidebarPaneUpdatedForTest", onSidebarRendered, true);
}
- function onAllScopesResolved()
+ function onSidebarRendered()
{
InspectorTest.expandScopeVariablesSidebarPane(onSidebarsExpanded);
}
@@ -36,7 +34,7 @@ function test()
<body onload="runTest()">
<p>
-Tests resolving variable names via source maps.
+Tests resolving this object name via source maps.
</p>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698