third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this.html - Issue 1884213003: DevTools: teach SourceMapNamesResolver to resolve "this" object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this.html

Issue 1884213003: DevTools: teach SourceMapNamesResolver to resolve "this" object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ids

Patch Set: fix tesst Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-identifiers.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-minified-variables.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this.html

similarity index 55%

copy from third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-minified-variables.html

copy to third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this.html

index f68dd9755a5bb13a49b85d725a23b3f225449ff9..400889effa780765bc741652bf74736e97ed7cf6 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-minified-variables.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scope-resolve-this.html

@@ -2,23 +2,21 @@

<head>

-<script src="resources/resolve-variable-names-compressed.js"></script>

+<script src="resources/resolve-this.js"></script>

function test()

{

Runtime.experiments.enableForTest("resolveVariableNames");

- InspectorTest.startDebuggerTest(() => InspectorTest.runTestFunctionAndWaitUntilPaused());

- var resolvedScopes = 0;

- InspectorTest.addSniffer(WebInspector.SourceMapNamesResolver, "_scopeResolvedForTest", onScopeResolved, true);

+ InspectorTest.waitForScriptSource("resolve-this.ts", onSourceMapLoaded);

- function onScopeResolved()

+ function onSourceMapLoaded()

{

- if (++resolvedScopes === 2)

- onAllScopesResolved();

+ InspectorTest.startDebuggerTest(() => InspectorTest.runTestFunctionAndWaitUntilPaused());

+ InspectorTest.addSniffer(WebInspector.ScopeChainSidebarPane.prototype, "_sidebarPaneUpdatedForTest", onSidebarRendered, true);

}

- function onAllScopesResolved()

+ function onSidebarRendered()

{

InspectorTest.expandScopeVariablesSidebarPane(onSidebarsExpanded);

}

@@ -36,7 +34,7 @@ function test()

<p>

-Tests resolving variable names via source maps.

+Tests resolving this object name via source maps.

</p>

</body>

</html>