Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1884193003: [arm] Turn off the default NaN mode on arm. (Closed)

Created:
4 years, 8 months ago by ahaas
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@arm64-default-nan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Turn off the default NaN mode on arm. The default NaN mode was originally used to identify holes in double arrays. With (https://codereview.chromium.org/863633002/) signalling NaNs are used for that, and the default NaN mode is not needed anymore. Without the default NaN mode it is easier to satisfy the WebAssembly spec which requires that quiet NaNs are preserved. R=titzer@chromium.org, rodolph.perfetta@arm.com, bmeurer@chromium.org Committed: https://crrev.com/5df9406a0708a779a51167c1700c1f87ec2ac3a3 Cr-Commit-Position: refs/heads/master@{#35526}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -52 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +3 lines, -27 lines 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ahaas
4 years, 8 months ago (2016-04-14 14:39:57 UTC) #1
Rodolph Perfetta (ARM)
lgtm
4 years, 8 months ago (2016-04-14 15:01:27 UTC) #2
Benedikt Meurer
Nice, LGTM.
4 years, 8 months ago (2016-04-14 18:35:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884193003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884193003/20001
4 years, 8 months ago (2016-04-15 12:16:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 12:45:05 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 12:45:35 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5df9406a0708a779a51167c1700c1f87ec2ac3a3
Cr-Commit-Position: refs/heads/master@{#35526}

Powered by Google App Engine
This is Rietveld 408576698