src/crankshaft/arm/lithium-codegen-arm.cc - Issue 1884193003: [arm] Turn off the default NaN mode on arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/arm/lithium-codegen-arm.cc

Issue 1884193003: [arm] Turn off the default NaN mode on arm. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@arm64-default-nan

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/arm/lithium-codegen-arm.cc

diff --git a/src/crankshaft/arm/lithium-codegen-arm.cc b/src/crankshaft/arm/lithium-codegen-arm.cc

index 45e13850562a967bf45f8750c930a84b3236f658..26b852039b67bf4be382f4cc7f22c9ceb811daaf 100644

--- a/src/crankshaft/arm/lithium-codegen-arm.cc

+++ b/src/crankshaft/arm/lithium-codegen-arm.cc

@@ -4030,11 +4030,6 @@ void LCodeGen::DoStoreKeyedFixedDoubleArray(LStoreKeyed* instr) {

if (instr->NeedsCanonicalization()) {

// Force a canonical NaN.

- if (masm()->emit_debug_code()) {

- __ vmrs(ip);

- __ tst(ip, Operand(kVFPDefaultNaNModeControlBit));

- __ Assert(ne, kDefaultNaNModeNotSet);

- }

__ VFPCanonicalizeNaN(double_scratch, value);

__ vstr(double_scratch, scratch, 0);

} else {

« no previous file with comments | « src/compiler/common-operator.cc ('k') | test/cctest/wasm/test-run-wasm.cc » ('j') | no next file with comments »