Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1883533003: Don't use the keyed slow stub for named handlers. (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't use the keyed slow stub for named handlers. Otherwise the megamorphic stubcache will miss. It only probes for non-keyed handlers. BUG= Committed: https://crrev.com/b9a2cf9e3b37b84bbc04ae0d5ed28ff04acf5387 Cr-Commit-Position: refs/heads/master@{#35492}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -79 lines) Patch
M src/ic/arm/ic-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm/stub-cache-arm.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/arm64/stub-cache-arm64.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/ic.h View 1 chunk +1 line, -6 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/ic/mips/stub-cache-mips.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/ic/mips64/stub-cache-mips64.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M src/ic/ppc/ic-ppc.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/ppc/stub-cache-ppc.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M src/ic/s390/ic-s390.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/s390/stub-cache-s390.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/x64/stub-cache-x64.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Toon Verwaest
ptal
4 years, 8 months ago (2016-04-12 11:51:30 UTC) #2
Jakob Kummerow
LGTM, but ia32/x87 look like they need more work. https://codereview.chromium.org/1883533003/diff/40001/src/ic/ia32/stub-cache-ia32.cc File src/ic/ia32/stub-cache-ia32.cc (right): https://codereview.chromium.org/1883533003/diff/40001/src/ic/ia32/stub-cache-ia32.cc#newcode30 src/ic/ia32/stub-cache-ia32.cc:30: ...
4 years, 8 months ago (2016-04-13 18:39:48 UTC) #3
Toon Verwaest
Undid the ia32/x87 changes in that file
4 years, 8 months ago (2016-04-14 12:38:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883533003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883533003/60001
4 years, 8 months ago (2016-04-14 12:39:25 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-14 13:01:26 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 13:01:46 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/b9a2cf9e3b37b84bbc04ae0d5ed28ff04acf5387
Cr-Commit-Position: refs/heads/master@{#35492}

Powered by Google App Engine
This is Rietveld 408576698