Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: src/ic/arm/ic-arm.cc

Issue 1883533003: Don't use the keyed slow stub for named handlers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic/arm/stub-cache-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 Handle<TypeFeedbackVector> dummy_vector = 678 Handle<TypeFeedbackVector> dummy_vector =
679 TypeFeedbackVector::DummyVector(masm->isolate()); 679 TypeFeedbackVector::DummyVector(masm->isolate());
680 int slot_index = dummy_vector->GetIndex( 680 int slot_index = dummy_vector->GetIndex(
681 FeedbackVectorSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot)); 681 FeedbackVectorSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot));
682 __ LoadRoot(vector, Heap::kDummyVectorRootIndex); 682 __ LoadRoot(vector, Heap::kDummyVectorRootIndex);
683 __ mov(slot, Operand(Smi::FromInt(slot_index))); 683 __ mov(slot, Operand(Smi::FromInt(slot_index)));
684 684
685 Code::Flags flags = 685 Code::Flags flags =
686 Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::STORE_IC)); 686 Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::STORE_IC));
687 masm->isolate()->stub_cache()->GenerateProbe( 687 masm->isolate()->stub_cache()->GenerateProbe(
688 masm, Code::STORE_IC, flags, receiver, key, r5, temporary2, r6, r9); 688 masm, Code::KEYED_STORE_IC, flags, receiver, key, r5, temporary2, r6, r9);
689 // Cache miss. 689 // Cache miss.
690 __ b(&miss); 690 __ b(&miss);
691 691
692 // Extra capacity case: Check if there is extra capacity to 692 // Extra capacity case: Check if there is extra capacity to
693 // perform the store and update the length. Used for adding one 693 // perform the store and update the length. Used for adding one
694 // element to the array by writing to array[array.length]. 694 // element to the array by writing to array[array.length].
695 __ bind(&extra); 695 __ bind(&extra);
696 // Condition code from comparing key and array length is still available. 696 // Condition code from comparing key and array length is still available.
697 __ b(ne, &slow); // Only support writing to writing to array[array.length]. 697 __ b(ne, &slow); // Only support writing to writing to array[array.length].
698 // Check for room in the elements backing store. 698 // Check for room in the elements backing store.
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
879 patcher.EmitCondition(ne); 879 patcher.EmitCondition(ne);
880 } else { 880 } else {
881 DCHECK(Assembler::GetCondition(branch_instr) == ne); 881 DCHECK(Assembler::GetCondition(branch_instr) == ne);
882 patcher.EmitCondition(eq); 882 patcher.EmitCondition(eq);
883 } 883 }
884 } 884 }
885 } // namespace internal 885 } // namespace internal
886 } // namespace v8 886 } // namespace v8
887 887
888 #endif // V8_TARGET_ARCH_ARM 888 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ic/arm/stub-cache-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698