Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ic/arm64/ic-arm64.cc

Issue 1883533003: Don't use the keyed slow stub for named handlers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm/stub-cache-arm.cc ('k') | src/ic/arm64/stub-cache-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 657 matching lines...) Expand 10 before | Expand all | Expand 10 after
668 DCHECK(!AreAliased(vector, slot, x5, x6, x7, x8)); 668 DCHECK(!AreAliased(vector, slot, x5, x6, x7, x8));
669 Handle<TypeFeedbackVector> dummy_vector = 669 Handle<TypeFeedbackVector> dummy_vector =
670 TypeFeedbackVector::DummyVector(masm->isolate()); 670 TypeFeedbackVector::DummyVector(masm->isolate());
671 int slot_index = dummy_vector->GetIndex( 671 int slot_index = dummy_vector->GetIndex(
672 FeedbackVectorSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot)); 672 FeedbackVectorSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot));
673 __ LoadRoot(vector, Heap::kDummyVectorRootIndex); 673 __ LoadRoot(vector, Heap::kDummyVectorRootIndex);
674 __ Mov(slot, Operand(Smi::FromInt(slot_index))); 674 __ Mov(slot, Operand(Smi::FromInt(slot_index)));
675 675
676 Code::Flags flags = 676 Code::Flags flags =
677 Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::STORE_IC)); 677 Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::STORE_IC));
678 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, flags, 678 masm->isolate()->stub_cache()->GenerateProbe(
679 receiver, key, x5, x6, x7, x8); 679 masm, Code::KEYED_STORE_IC, flags, receiver, key, x5, x6, x7, x8);
680 // Cache miss. 680 // Cache miss.
681 __ B(&miss); 681 __ B(&miss);
682 682
683 __ Bind(&extra); 683 __ Bind(&extra);
684 // Extra capacity case: Check if there is extra capacity to 684 // Extra capacity case: Check if there is extra capacity to
685 // perform the store and update the length. Used for adding one 685 // perform the store and update the length. Used for adding one
686 // element to the array by writing to array[array.length]. 686 // element to the array by writing to array[array.length].
687 687
688 // Check for room in the elements backing store. 688 // Check for room in the elements backing store.
689 // Both the key and the length of FixedArray are smis. 689 // Both the key and the length of FixedArray are smis.
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
858 } else { 858 } else {
859 DCHECK(to_patch->Mask(TestBranchMask) == TBNZ); 859 DCHECK(to_patch->Mask(TestBranchMask) == TBNZ);
860 // This is JumpIfSmi(smi_reg, branch_imm). 860 // This is JumpIfSmi(smi_reg, branch_imm).
861 patcher.tbz(smi_reg, 0, branch_imm); 861 patcher.tbz(smi_reg, 0, branch_imm);
862 } 862 }
863 } 863 }
864 } // namespace internal 864 } // namespace internal
865 } // namespace v8 865 } // namespace v8
866 866
867 #endif // V8_TARGET_ARCH_ARM64 867 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/ic/arm/stub-cache-arm.cc ('k') | src/ic/arm64/stub-cache-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698